Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Updated test/integration/core/dns reverse test to remove flaki… #2121

Merged
merged 1 commit into from
Apr 3, 2024
Merged

chore: Updated test/integration/core/dns reverse test to remove flaki… #2121

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 10 additions & 17 deletions test/integration/core/dns.tap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,26 +128,19 @@ test('resolveSrv', function (t) {
})

test('reverse', function (t) {
const reverse = dns.reverse
dns.reverse = (addr, cb) => {
cb(undefined, ['localhost'])
}
t.teardown(() => {
dns.reverse = reverse
})

const agent = setupAgent(t)
helper.runInTransaction(agent, function () {
dns.reverse('127.0.0.1', function (err, names) {
t.notOk(err, 'should not error')
let expected = []
if (names.length > 0) {
if (process.env.DOCKERIZED) {
if (names.length === 2) {
expected = ['127.0.0.1', 'localhost']
} else {
expected = ['localhost']
}
} else {
expected = ['nettuno', 'travis', 'vagrant']
}
}

expected.forEach((name) => {
t.not(names.indexOf(name), -1, 'should have expected name')
})
t.error(err, 'should not error')
t.not(names.indexOf('localhost'), -1, 'should have expected name')
verifySegments(t, agent, 'dns.reverse')
})
})
Expand Down
Loading