ci: Updated prepare-release.js to not require changelog.json
#2106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2106 +/- ##
=======================================
Coverage 97.21% 97.21%
=======================================
Files 251 251
Lines 42392 42392
=======================================
Hits 41210 41210
Misses 1182 1182
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jsumners-nr
previously approved these changes
Apr 2, 2024
Co-authored-by: James Sumners <[email protected]>
jsumners-nr
approved these changes
Apr 2, 2024
This was referenced Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
bin/prepare-release.jsscript has logic to generate a changelog in both markdown and json. The json gets written to changelog.json which is subsequently parsed and used to open a docs PR with front matter for the given release. This logic is only needed fornode-newrelic. When we migrated all of our others repos we had to add a changelog.json which writes features, bugs and security fixes but it's never used. This PR provides the ability to optionally pass in a flag--changelog-jsonto write out the changes to changelog.json which will only be used in node-newrelic, which you can see is being done in.github/workflows/prepare-release.yml. Once this is merged we can update all external repos to remove thechangelog.jsonHow to Test
Related Issues
Closes #2105