-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fixed instrumenting the same module installed in different locations #2104
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments but hard to see the state of this atm because there's a merge conflict. I'll continue review after that is addressed
6eba1b8
to
94272c8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2104 +/- ##
==========================================
- Coverage 97.20% 97.19% -0.01%
==========================================
Files 251 250 -1
Lines 42317 42317
==========================================
- Hits 41133 41132 -1
- Misses 1184 1185 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work. I know this was one was a tough one. Great job abstacting away the tracking and registration of instrumentation. I verified the new test proves the intent of this PR. I also ran the versioned tests with security agent. Lastly, compare coverage of unit and integration tests between this and main to ensure we didn't lose test coverage 🚀
This PR resolves #2033.
Before we can merge this PR, we need to: