Don't crash when using mongodb driver 2.0.16 #194
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually, woops, didn't look at the PRs and so didn't see discussion on #193. Feel free to close if you deem it necessary. But hopefully the fact that you can get collection name from cursor helps :) |
|
Thanks for looking in to this, we have an updated version of our mongo instrumentation that we are releasing very soon that supports getting collection names across various versions of mognodb. I'll add a note here when its released. |
|
Much thanks, I'm looking forward to the release. In the meantime, feel free to report any issues you run into on our JIRA board. |
|
a fix for this is released in 1.17.0 |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the companies that's been helping QA the new version of the mongodb driver uses New Relic in their test environment, and turns out the New Relic agent crashes ungracefully with the new version of the driver. See Automattic/mongoose#2652 and mongodb/node-mongodb-native#1253. We added the ability to get the collection name from the cursor back into the driver for v2.0.16. I'm not sure if this is the correct way to handle this on your end, but this tweak seems to be enough to at least make the agent stop crashing.