fix: Replace request.abort with response.close in HTTP instrumentation #1510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NR-88357 In Node.js 16, there was a breaking change where request.aborted will no longer be emitted by the HTTP Node core. Instead, we will now rely on response.close, which works in all currently supported versioned of node (14/16/18)
Codecov Report
@@ Coverage Diff @@
## main #1510 +/- ##
=======================================
Coverage 96.39% 96.39%
=======================================
Files 196 196
Lines 38193 38198 +5
Branches 23 23
=======================================
+ Hits 36817 36822 +5
Misses 1376 1376
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
bizob2828
requested changes
Feb 17, 2023
|
|
||
| 'use strict' | ||
|
|
||
| // Polyfill till we drop support for Node 14 |
There was a problem hiding this comment.
Should we cut a ticket to remove this when we drop 14?
There was a problem hiding this comment.
I actually replaced the abort controller with request.destroy, so no need to use the abort controller anymore
bizob2828
approved these changes
Feb 21, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Release Notes
request.abortedwithresponse.closein HTTP instrumentation.Links
autoDestroy: truein incoming message nodejs/node#33035Details
In Node.js 16, there was a breaking change where
request.abortedwill no longer be emitted by the HTTP Node core. Instead, we will now rely onresponse.close, which works in all currently supported versioned of node (14/16/18)