handle ignore_status_codes defined as strings #109
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return expect(urltils.isError(config, 401)).false; | ||
| }); | ||
|
|
||
| it("should handle ignore_status_codes defined as integers", function () { |
There was a problem hiding this comment.
this was working before, just added one more test to make sure
|
Ah, this would explain a bug people have been seeing intermittently since the launch of the module. Good find! Thanks for passing this on! Because |
|
Good point. |
|
Hi, Pierre! Sorry for the delay, but this is now fixed in 7d3b835, which is part of v1.3.1 of the module, now on npm. Thanks for the report! |
|
👍 |
cmcadams-newrelic
pushed a commit
to cmcadams-newrelic/node-newrelic
that referenced
this pull request
Jan 29, 2024
…/prisma-app/app/semver-6.3.1 chore(deps): bump semver from 6.3.0 to 6.3.1 in /prisma-app/app
jsumners-nr
pushed a commit
to jsumners-nr/node-newrelic
that referenced
this pull request
Apr 11, 2024
…/protobufjs-7.2.4 Bump protobufjs from 7.2.3 to 7.2.4
jsumners-nr
pushed a commit
to jsumners-nr/node-newrelic
that referenced
this pull request
Apr 16, 2024
…/urijs-1.19.9 Bump urijs from 1.19.8 to 1.19.9
bizob2828
pushed a commit
to bizob2828/node-newrelic
that referenced
this pull request
Apr 19, 2024
updates the sns instrumentation based on the onResolved hook
bizob2828
pushed a commit
to bizob2828/node-newrelic
that referenced
this pull request
Apr 23, 2024
updates the sns instrumentation based on the onResolved hook
bizob2828
added a commit
to bizob2828/node-newrelic
that referenced
this pull request
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should solve the problem with
NEW_RELIC_ERROR_COLLECTOR_IGNORE_ERROR_CODESnot working as expected.For example, if you want to ignore in your 401 errors, and 404 errors, you can set:
and it should work with that change.