Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash in http.createClient #80

Closed
groundwater opened this issue Nov 7, 2013 · 2 comments
Closed

Crash in http.createClient #80

groundwater opened this issue Nov 7, 2013 · 2 comments

Comments

@groundwater
Copy link
Contributor

Reproduce with:

require('newrelic');

var http = require('http');

http.createServer(function (req, res) {
  var client = http.createClient(80, 'localhost');
  res.end();
}).listen(8080);

Then curl localhost:8080 to kill the server with

TypeError: Parameter 'url' must be a string, not undefined
    at Url.parse (url.js:107:11)
    at Object.urlParse [as parse] (url.js:101:5)
    at Object.scrub (node_modules/newrelic/lib/util/urltils.js:42:20)
    at instrumentOutbound (node_modules/newrelic/lib/transaction/tracer/instrumentation/outbound.js:20:60)
    at Object.wrappedCreateClient (node_modules/newrelic/lib/instrumentation/core/http.js:94:7)
    at Object.b (domain.js:183:18)
    at Object.<anonymous> (node_modules/newrelic/node_modules/continuation-local-storage/context.js:57:17)
    at node_modules/newrelic/lib/transaction/tracer.js:239:22
    at ErrorTracer.monitor (node_modules/newrelic/lib/error.js:179:12)
    at Tracer.monitor (node_modules/newrelic/lib/transaction/tracer.js:237:28)
@groundwater
Copy link
Contributor Author

It looks like this line is expecting a request.path but the path property does not exist on the client object.

https://github.com/newrelic/node-newrelic/blob/master/lib/transaction/tracer/instrumentation/outbound.js#L20

@othiym23
Copy link
Contributor

othiym23 commented Nov 9, 2013

Fixed by d7f54ee. Thanks for making this tracking issue!

@othiym23 othiym23 closed this as completed Nov 9, 2013
cmcadams-newrelic pushed a commit to cmcadams-newrelic/node-newrelic that referenced this issue Jan 29, 2024
…prisma-app/app/fast-xml-parser-and-aws-sdk/client-lambda-4.2.5

chore(deps): bump fast-xml-parser and @aws-sdk/client-lambda in /prisma-app/app
jsumners-nr pushed a commit to jsumners-nr/node-newrelic that referenced this issue Apr 11, 2024
7.1.1 was released, updating semver range to only exclude 7.1.0
jsumners-nr pushed a commit to jsumners-nr/node-newrelic that referenced this issue Apr 16, 2024
bizob2828 added a commit to bizob2828/node-newrelic that referenced this issue Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants