Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

newrelic module needs a lot of storage space #77

Closed
Prinzhorn opened this issue Oct 31, 2013 · 5 comments
Closed

newrelic module needs a lot of storage space #77

Prinzhorn opened this issue Oct 31, 2013 · 5 comments

Comments

@Prinzhorn
Copy link

I've noticed that my slug size on Heroku (https://devcenter.heroku.com/articles/slug-compiler) increased from about 30megs to over 70megs just because I added the newrelic module.

Running du | sort -g on the dyno these are the bottom lines

13320   ./.npm/newrelic/1.0.1/package/test/versioned/express3-mongodb-async/node_modules/mongodb/.coverage_data
13320   ./node_modules/newrelic/test/versioned/express3-mongodb-async/node_modules/mongodb/.coverage_data
15220   ./.npm/newrelic/1.0.1/package/test/versioned/express3-mongodb-async/node_modules/mongodb
15220   ./node_modules/newrelic/test/versioned/express3-mongodb-async/node_modules/mongodb
18140   ./.npm/newrelic/1.0.1/package/test/versioned/express3-mongodb-async/node_modules
18140   ./node_modules/newrelic/test/versioned/express3-mongodb-async/node_modules
18160   ./.npm/newrelic/1.0.1/package/test/versioned/express3-mongodb-async
18160   ./node_modules/newrelic/test/versioned/express3-mongodb-async
54960   ./.npm/newrelic/1.0.1/package/test/versioned
54960   ./node_modules/newrelic/test/versioned
58272   ./.npm/newrelic/1.0.1/package/test
58272   ./node_modules/newrelic/test
59708   ./.npm/newrelic/1.0.1/package
59732   ./node_modules/newrelic
74324   ./.npm/newrelic/1.0.1
74856   ./.npm/newrelic
101136  ./node_modules
134832  ./.npm
258384  .

I don't think the /test folder should be part of the release on npm. I suggest adding a .npmignore file.

Funny enough, on my dev machine the test folder only weighs about 1meg, whereas it's 57meg on Heroku.

@Prinzhorn
Copy link
Author

I was still on 1.0.0 locally. Upgrading to 1.0.1 results in 57mb /test folder as well. This increases build time significantly.

@othiym23
Copy link
Contributor

This is due to an npm bug related to how it deals with the combination of bundledDependencies and multiple node_modules folders in a repo. That module should be around 300KiB as a tarball, but I forgot a step in the build process. I'll republish 1.0.1 in a more svelte form later today.

@Prinzhorn
Copy link
Author

Great, thanks!

@othiym23
Copy link
Contributor

Republished a bazillion times smaller. Sorry about that!

@Prinzhorn
Copy link
Author

Confirmed. Dropped from 59M to 2.6M

cmcadams-newrelic pushed a commit to cmcadams-newrelic/node-newrelic that referenced this issue Jan 29, 2024
…4d889c9d6de9abfff

[Snyk] Security upgrade newrelic from 9.5.0 to 10.3.1
jsumners-nr pushed a commit to jsumners-nr/node-newrelic that referenced this issue Apr 11, 2024
changing gh token to the org level value
jsumners-nr pushed a commit to jsumners-nr/node-newrelic that referenced this issue Apr 16, 2024
bizob2828 pushed a commit to bizob2828/node-newrelic that referenced this issue Apr 19, 2024
bizob2828 pushed a commit to bizob2828/node-newrelic that referenced this issue Apr 23, 2024
bizob2828 added a commit to bizob2828/node-newrelic that referenced this issue Jul 26, 2024
…moment-2.29.4

Bump moment from 2.29.2 to 2.29.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants