Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proxy test coverage #144

Closed
elliottheis opened this issue May 19, 2014 · 1 comment
Closed

Proxy test coverage #144

elliottheis opened this issue May 19, 2014 · 1 comment

Comments

@elliottheis
Copy link

There seems to be a use case missing in the test coverage to ensure that the proxy host has been set correctly in the request object - currently only the path seems to be inspected as an assurance.
@txase
Copy link

txase commented Jun 26, 2014

Hi @elliottheis,

Our proxy support is currently half-baked. We don't support HTTP proxies yet, but we are currently working on it. Look for it in an upcoming release!

I'm closing this issue now as it's for a feature we don't support yet.

@txase txase closed this as completed Jun 26, 2014
cmcadams-newrelic pushed a commit to cmcadams-newrelic/node-newrelic that referenced this issue Jan 29, 2024
@mrickard
Merge pull request newrelic#144 from newrelic/snyk-fix-12259adcd3a60c…
f1e9a9b 
…b999e349fe77197aa4

[Snyk] Security upgrade newrelic from 10.3.1 to 11.5.0
jsumners-nr pushed a commit to jsumners-nr/node-newrelic that referenced this issue Apr 16, 2024
@bizob2828
Merge pull request newrelic#144 from bizob2828/moar-shim-fixes
639d029 
updated tests to include shimName when registering instrumentation. also updated index.js to include shimName as that was missed from last time
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@elliottheis @txase