1.2.0 produces restify errors

[bsander]

Immediately after upgrading newrelic from 1.1.1 to 1.2.0 in our restify server, all requests fail with two different error messages:

This error is emitted through our HTML formatter upon a valid request:

error: [Formatter:HTML]   Object function ( w ) {
                if ( !w.document ) {
                    throw new Error( "jQuery requires a window with a document" );
                }
                return factory( w );
            } has no method 'param'
    at Server.<anonymous> (/Users/Sander/src/some-project/node_modules/restify/lib/index.js:87:26)
    at Server.EventEmitter.emit (events.js:106:17)
    at Domain.onError (/Users/Sander/src/some-project/node_modules/restify/lib/server.js:780:30)
    at Domain.EventEmitter.emit (events.js:95:17)
    at process._fatalException (node.js:249:27)
    at process._asyncFatalException [as _fatalException] (/Users/Sander/src/some-project/node_modules/newrelic/node_modules/continuation-local-storage/node_modules/async-listener/glue.js:199:34)

And worse, this uncaught exception is produced when a non-existant route is requested:

error: [Formatter:HTML]   /favicon.ico does not exist

/Users/Sander/src/some-project/node_modules/newrelic/node_modules/continuation-local-storage/context.js:66
      throw exception;
            ^
TypeError: Property 'undefined' of object  is not a function
    at ServerResponse.formatter (/Users/Sander/src/some-project/lib/formatter/htmlformatter.js:40:37)
    at ServerResponse.format (/Users/Sander/src/some-project/node_modules/restify/lib/response.js:104:27)
    at ServerResponse.send (/Users/Sander/src/some-project/node_modules/restify/lib/response.js:207:32)
    at emitRouteError (/Users/Sander/src/some-project/node_modules/restify/lib/server.js:151:21)
    at onRoute (/Users/Sander/src/some-project/node_modules/restify/lib/server.js:623:33)
    at wrapped (/Users/Sander/src/some-project/node_modules/newrelic/lib/instrumentation/restify.js:63:16)
    at Router.find (/Users/Sander/src/some-project/node_modules/restify/lib/router.js:473:9)
    at Router.wrappedFind [as find] (/Users/Sander/src/some-project/node_modules/newrelic/lib/instrumentation/restify.js:66:19)
    at Server._route (/Users/Sander/src/some-project/node_modules/restify/lib/server.js:617:21)
    at routeAndRun (/Users/Sander/src/some-project/node_modules/restify/lib/server.js:576:22)

I'm not sure what information I should provide about our application, maybe the stacktraces alone are enough for you guys. If not, please ask!

[othiym23]

Hey Sander, sorry that you've run into another problem with New Relic. I'll see if I can reproduce your problem from these stacktraces and will let you know if that's not enough. One quick question: are you still using longjohn in your Restify app(s)? We were able to fix the conflict between CLS and longjohn before, but maybe there's something else that gets exercised by adding Restify into the mix.

[bsander]

Hi Forrest, you have a good memory ;) I checked and longjohn is still disabled for the app (it obviously hasn't acted on the stacktraces above). Thanks for looking into it!

[bsander]

Hi Forrest, any progress on this?

[othiym23]

Right now I'm working on coming up with a test case where I can see the error. We have functional tests for Restify, and they're working fine. What's the middleware configuration for your app look like?

[bsander]

Over the course of the last week we finally traced these errors to unrelated causes. We were apparently blindsided by a combination of the trace messages leading to newrelic, the fact that it happened upon an npm update and some distracting cache rot. I'll close this now, sorry for the inconvenience.

[othiym23]

My favorite kind of issues! Sorry we couldn't be of more use to you in bringing this to a speedy resolution, though. Thanks for the followup!