only need one condition

newrelic · May 21, 2024 · d818987 · d818987
1 parent e42937a
commit d818987
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 25 deletions.
diff --git a/.github/workflows/ci-workflow.yml b/.github/workflows/ci-workflow.yml
@@ -12,30 +12,25 @@ jobs:
     permissions:
       pull-requests: read
     outputs:
-      javascript_changed: ${{ steps.filter.output.javascript }}
-      release_files_changed: ${{ steps.filter.output.release_related_files }}
+      javascript_changed: ${{ steps.filter.outputs.javascript }}
     steps:
       - uses: actions/checkout@v4
       - uses: dorny/paths-filter@v3
         id: filter
         with:
           filters: |
             javascript:
-              - '**/*.js'
-              - '**/*.json'
-              - '**/*.mjs'
-              - '**/*.cjs'
-            release_related_files:
-              - 'NEWS.md'
-              - 'changelog.json'
-              - 'package.json'
-              - 'package-lock.json'
+              - 'api.js'
+              - 'esm-loader.mjs'
+              - 'index.js'
+              - 'stub_api.js'
+              - 'lib/**/*.{js,json,mjs,cjs}'
+              - 'test/**/*.{js,json,mjs,cjs}'
 
   lint:
     needs:
       - should_run
-    if: needs.should_run.outputs.release_files_changed == 'false'
-      || needs.should_run.outputs.javascript_changed == 'true'
+    if: needs.should_run.outputs.javascript_changed == 'true'
     runs-on: ubuntu-latest
 
     strategy:
@@ -58,8 +53,7 @@ jobs:
   ci:
     needs:
       - should_run
-    if: needs.should_run.outputs.release_files_changed == 'false'
-      || needs.should_run.outputs.javascript_changed == 'true'
+    if: needs.should_run.outputs.javascript_changed == 'true'
     runs-on: ubuntu-latest
 
     strategy:
@@ -81,8 +75,7 @@ jobs:
   unit:
     needs:
       - should_run
-    if: needs.should_run.outputs.release_files_changed == 'false'
-      || needs.should_run.outputs.javascript_changed == 'true'
+    if: needs.should_run.outputs.javascript_changed == 'true'
     runs-on: ubuntu-latest
 
     strategy:
@@ -109,8 +102,7 @@ jobs:
   integration:
     needs:
       - should_run
-    if: needs.should_run.outputs.release_files_changed == 'false'
-      || needs.should_run.outputs.javascript_changed == 'true'
+    if: needs.should_run.outputs.javascript_changed == 'true'
     runs-on: ubuntu-latest
 
     env:
@@ -149,8 +141,7 @@ jobs:
   versioned-internal:
     needs:
       - should_run
-    if: needs.should_run.outputs.release_files_changed == 'false'
-      || needs.should_run.outputs.javascript_changed == 'true'
+    if: needs.should_run.outputs.javascript_changed == 'true'
     runs-on: ${{ github.ref == 'refs/heads/main' && vars.NR_RUNNER || 'ubuntu-latest' }}
 
     strategy:
@@ -199,8 +190,7 @@ jobs:
   versioned-external:
     needs:
       - should_run
-    if: needs.should_run.outputs.release_files_changed == 'false'
-      || needs.should_run.outputs.javascript_changed == 'true'
+    if: needs.should_run.outputs.javascript_changed == 'true'
     runs-on: ${{ github.ref == 'refs/heads/main' && vars.NR_RUNNER || 'ubuntu-latest' }}
 
     strategy:

diff --git a/index.js b/index.js
@@ -5,8 +5,6 @@
 
 'use strict'
 
-// testing
-
 // Record opening times before loading any other files.
 const preAgentTime = process.uptime()
 const agentStart = Date.now()