refactor: got rid of redundant isExpected in the Exception class (#2328)

lib/errors/index.js

@@ -31,19 +31,18 @@ class Exception {
 
   getErrorDetails(config) {
     const errorDetails = errorHelper.extractErrorInformation(null, this.error, config)
-    errorDetails.expected = this.isExpected(config, errorDetails)
-
-    return errorDetails
-  }
-
-  isExpected(config, { type, message }) {
     if (typeof this._expected === 'undefined') {
-      this._expected =
-        errorHelper.isExpectedErrorClass(config, type) ||
-        errorHelper.isExpectedErrorMessage(config, type, message)
+      this._expected = errorHelper.isExpected(
+        errorDetails.type,
+        errorDetails.message,
+        null,
+        config,
+        urltils
+      )
     }
+    errorDetails.expected = this._expected
 
-    return this._expected
+    return errorDetails
   }
 }