Skip to content

Add Bundler version conditions#2823

Merged
hannahramadan merged 8 commits intodevfrom
shhhh_bundler
Aug 21, 2024
Merged

Add Bundler version conditions#2823
hannahramadan merged 8 commits intodevfrom
shhhh_bundler

Conversation

@hannahramadan
Copy link
Contributor

@hannahramadan hannahramadan commented Aug 20, 2024 •
edited
Loading

Bundler 2+ deprecated all_specs in favor of installed_specs and emits warnings when all_specs is used. We still support Bundler 1, so need to keep all_specs around while using installed_specs when appropriate.

Checking for the version proved faster in benchmarking than checking to see if installed_specs is defined.

closes #2733

@hannahramadan hannahramadan changed the title Bundler version conditions Add Bundler version conditions Aug 20, 2024
@hannahramadan hannahramadan marked this pull request as ready for review August 20, 2024 20:08
fallwith
fallwith reviewed Aug 20, 2024
View reviewed changes
fallwith
fallwith reviewed Aug 20, 2024
View reviewed changes
hannahramadan and others added 3 commits August 20, 2024 13:48
fallwith
fallwith reviewed Aug 20, 2024
View reviewed changes
hannahramadan and others added 2 commits August 20, 2024 16:22
@hannahramadan @fallwith
Update lib/new_relic/agent/instrumentation/grape.rb
f01f972 
Co-authored-by: James Bunch <fallwith@gmail.com>
@hannahramadan
parens
8c954c1
fallwith
fallwith previously approved these changes Aug 20, 2024
View reviewed changes
kaylareopelle
kaylareopelle previously approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@kaylareopelle kaylareopelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, as-is! A few small suggestions.

@hannahramadan hannahramadan dismissed stale reviews from kaylareopelle and fallwith via b33eac4 August 21, 2024 17:06
@github-actions
Copy link
Contributor

github-actions bot commented Aug 21, 2024

SimpleCov Report

Coverage Threshold
Line 93.82% 93%
Branch 70.35% 50%

kaylareopelle
kaylareopelle approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@kaylareopelle kaylareopelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@hannahramadan hannahramadan merged commit a885001 into dev Aug 21, 2024
@hannahramadan hannahramadan deleted the shhhh_bundler branch August 21, 2024 18:13
@hannahramadan hannahramadan mentioned this pull request Aug 21, 2024
Closed
@mitchellhenke mitchellhenke mentioned this pull request Jan 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kaylareopelle kaylareopelle kaylareopelle approved these changes

@tannalynn tannalynn Awaiting requested review from tannalynn

+1 more reviewer

@fallwith fallwith fallwith left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

Ruby Engineering Board
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Avoid deprecated Bundler method all_specs

3 participants

@hannahramadan @fallwith @kaylareopelle