Skip Active Support Logger instrumentation for Rails 7.1#2246
Merged
kaylareopelle merged 1 commit intodevfrom Oct 9, 2023
Merged
Conversation
kaylareopelle
requested review from
fallwith,
hannahramadan and
tannalynn
as code owners
kaylareopelle
force-pushed
the
skip-active-support-logger-instrumentation-for-rails-71
branch
from
83aab80 to
ba64660
Compare
kaylareopelle
added
core technology
rails
fallwith
previously approved these changes
Oct 9, 2023
The private method ActiveSupport::Logger.broadcast has been removed in Rails 7.1. This throws an error in our tests. It also prevents the @skip_instrumenting instance variable from being set on broadcasted loggers. This may cause users of Rails 7.1 to send duplicate log events to New Relic. This change stops ActiveSupport::Logger instrumentation from being installed on Rails 7.1 or above. This is intended to be a temporary measure until a solution can be found to stop sending duplicate logs in Rails 7.1.
kaylareopelle
force-pushed
the
skip-active-support-logger-instrumentation-for-rails-71
branch
from
ba64660 to
257aeb3
Compare
tannalynn
approved these changes
Oct 9, 2023
kaylareopelle
deleted the
skip-active-support-logger-instrumentation-for-rails-71
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The private method ActiveSupport::Logger.broadcast has been removed
in Rails 7.1. This throws an error in our tests. It also prevents the
@skip_instrumenting instance variable from being set on broadcast
loggers. This may cause users of Rails 7.1 to send duplicate
log events to New Relic.
This change stops ActiveSupport::Logger instrumentation from being
installed on Rails 7.1 or above. This is intended to be a temporary
measure until a solution can be found to stop sending duplicate logs
in Rails 7.1.