Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Vantage tile #2585

Merged
merged 1 commit into from
Oct 28, 2024
Merged

feat: Vantage tile #2585

merged 1 commit into from
Oct 28, 2024

Conversation

jcountsNR
Copy link
Contributor

@jcountsNR jcountsNR commented Oct 9, 2024

Summary

Simple Vantage quickstart, pointing out the integration there with Vantage. They are a cloud cost company that monitors cloud spend across all cloud providers (AWS, GCP, Azure, and other cloud tools including NR.)

Pre merge checklist

  • Did you check you NRQL syntax? - Does it work?
  • Did you include a Data source and Documentation reference?
  • Are all documentation links publicly accessible?
  • Did you check your descriptive content for voice and tone?
  • Did you check your descriptive content for spelling and grammar errors?
  • Did you review your content with a subject matter expert? (e.g. a Browser agent quickstart is reviewed with a member of the Browser Agent team)

Copy link
Contributor

@RamanaReddy8801 RamanaReddy8801 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@RamanaReddy8801 RamanaReddy8801 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jcountsNR, I have noticed that this integration doesn't have a datasource. Please update the datasource for this integration. below is the sample template link to use for creating a datasource: https://github.com/newrelic/newrelic-quickstarts/blob/main/_template/data-sources/example-data-source/config.yml.

@jcountsNR
Copy link
Contributor Author

Hi @RamanaReddy8801 , there is no datasource here since this is a cloud pricing tool. They export the data from nerdgraph and use it to view their cloud spend alongside aws/azure/etc.

Copy link
Contributor

@sjyothi54 sjyothi54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@sjyothi54 sjyothi54 merged commit fccd8b5 into release Oct 28, 2024
12 checks passed
@sjyothi54 sjyothi54 deleted the jc-vantage branch October 28, 2024 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants