-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to artifact to conform to service structs #2583
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephgregoryii
commented
Oct 7, 2024
josephgregoryii
force-pushed
the
tweak-artifact
branch
from
October 7, 2024 20:17
6f2c054
to
c3163e9
Compare
josephgregoryii
force-pushed
the
tweak-artifact
branch
from
October 9, 2024 16:57
0187776
to
be33c35
Compare
josephgregoryii
force-pushed
the
tweak-artifact
branch
from
October 9, 2024 17:03
8fd52e8
to
0c04dba
Compare
josephgregoryii
force-pushed
the
tweak-artifact
branch
from
October 15, 2024 20:04
3484fd6
to
e2a8020
Compare
d3caf
reviewed
Oct 17, 2024
d3caf
approved these changes
Oct 17, 2024
mickeyryan42
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
While working on the server side of the quickstart ecosystem, we noticed that there are a lot of connected structs between data sources, quickstarts, alerts and dashboards. On top of that, we actually lose a lot of functionality by not going through a mutation pipeline that helps "transform" the quickstarts / components into proper structs for the database
This PR is to re-configure the artifact and schema. The schema takes shape closely to what the service and data base expect.