-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config, data source, dashboard for Bitmovin integration #2574
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @cjmccarthy, below is the sample template link to use for creating a Quickstart: https://github.com/newrelic/newrelic-quickstarts/tree/main/_template. Please ensure that the content of config.yml
is specifically related to Bitmovin.
Thanks for catching that, I had the wrong version of the file submitted. It's fixed now. |
Hi @RamanaReddy8801 is this ok to merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @cjmccarthy, please update the logo.svg
image in quickstart/bitmovin
as well.
data-sources/bitmovin/config.yml
Outdated
install: | ||
primary: | ||
nerdlet: | ||
nerdletId: marketplace.install-data-source | ||
nerdletState: | ||
dataSourceId: bitmovin-video | ||
frameworkConfigId: bitmovin-video | ||
requiresAccount: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have noticed that this integration does not have an install framework. Therefore, we need to add one as per the sample template: https://github.com/newrelic/newrelic-quickstarts/blob/main/_template/data-sources/example-data-source/config.yml.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, sorry about that. Updated to link to github now, where we have documented the install instructions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added the logo.svg there as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Summary
Adding a quickstart for our bitmovin integration.
Pre merge checklist
Dashboards