Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config, data source, dashboard for Bitmovin integration #2574

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

cjmccarthy
Copy link
Contributor

@cjmccarthy cjmccarthy commented Sep 27, 2024

Summary

Adding a quickstart for our bitmovin integration.

Pre merge checklist

  • [x ] Did you check you NRQL syntax? - Does it work?
  • [ x] Did you include a Data source and Documentation reference?
  • [x ] Are all documentation links publicly accessible?
  • [ x] Did you check your descriptive content for voice and tone?
  • [ x] Did you check your descriptive content for spelling and grammar errors?
  • [ x] Did you review your content with a subject matter expert? (e.g. a Browser agent quickstart is reviewed with a member of the Browser Agent team)

Dashboards

  • [ x] Does the PR contain a screenshot for each of your dashboards?
  • [ x]x Do your screenshots show data?
  • [ x] Has the sanitization script been run on each dashboard?

@CLAassistant
Copy link

CLAassistant commented Sep 27, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@RamanaReddy8801 RamanaReddy8801 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @cjmccarthy, below is the sample template link to use for creating a Quickstart: https://github.com/newrelic/newrelic-quickstarts/tree/main/_template. Please ensure that the content of config.yml is specifically related to Bitmovin.

@cjmccarthy
Copy link
Contributor Author

Hi @cjmccarthy, below is the sample template link to use for creating a Quickstart: https://github.com/newrelic/newrelic-quickstarts/tree/main/_template. Please ensure that the content of config.yml is specifically related to Bitmovin.

Thanks for catching that, I had the wrong version of the file submitted. It's fixed now.

@cjmccarthy
Copy link
Contributor Author

Hi @RamanaReddy8801 is this ok to merge?

Copy link
Contributor

@RamanaReddy8801 RamanaReddy8801 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @cjmccarthy, please update the logo.svg image in quickstart/bitmovin as well.

Comment on lines 6 to 13
install:
primary:
nerdlet:
nerdletId: marketplace.install-data-source
nerdletState:
dataSourceId: bitmovin-video
frameworkConfigId: bitmovin-video
requiresAccount: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have noticed that this integration does not have an install framework. Therefore, we need to add one as per the sample template: https://github.com/newrelic/newrelic-quickstarts/blob/main/_template/data-sources/example-data-source/config.yml.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, sorry about that. Updated to link to github now, where we have documented the install instructions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added the logo.svg there as well

Copy link
Contributor

@sjyothi54 sjyothi54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Contributor

@RamanaReddy8801 RamanaReddy8801 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@pkudikyala pkudikyala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pkudikyala pkudikyala merged commit 281a514 into newrelic:release Oct 24, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants