Refactor and clean up actions/worfklows #2555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d3caf
requested review from
a team,
josephgregoryii and
mickeyryan42
and removed request for
a team
mickeyryan42
previously approved these changes
Sep 13, 2024
Comment on lines
-17
to
-18
| nr-api-url: ${{ secrets.NR_API_URL_EU }} | ||
| nr-api-token: ${{ secrets.NR_API_TOKEN_EU }} |
There was a problem hiding this comment.
We might wanna considering removing any secrets from the repo that we arent using after we remove these workflows / actions.
We do have a bot that might need these just to mention.
|
@josephgregoryii raining on the deletion parade 😞 |
d3caf
force-pushed
the
andrew/NR-311556-actions-cleanup
branch
from
e0d0aba to
ae6bdee
Compare
josephgregoryii
approved these changes
Sep 16, 2024
mickeyryan42
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the changes we've made to our validation/submission workflows, we no longer need many of the previous actions. This PR removes them and tries to consolidate things a bit as well.