feat: Validation and release on main push #2549
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Mickey Ryan <[email protected]>
Co-authored-by: Mickey Ryan <[email protected]>
Co-authored-by: Mickey Ryan <[email protected]>
…main Co-authored-by: Mickey Ryan <[email protected]>
Co-authored-by: Mickey Ryan <[email protected]>
d3caf
force-pushed
the
andrew/NR-268466-main-validation
branch
from
74fa0a7 to
0216c71
Compare
d3caf
force-pushed
the
andrew/NR-268466-main-validation
branch
from
0216c71 to
99be0d1
Compare
d3caf
force-pushed
the
andrew/NR-268466-main-validation
branch
2 times, most recently
from
824958b to
7a7c2f7
Compare
d3caf
force-pushed
the
andrew/NR-268466-main-validation
branch
from
7a7c2f7 to
6b9d076
Compare
d3caf
force-pushed
the
andrew/NR-268466-main-validation
branch
from
bc1767b to
1792779
Compare
Co-authored-by: Mickey Ryan <[email protected]>
Co-authored-by: Mickey Ryan <[email protected]>
Co-authored-by: Mickey Ryan <[email protected]>
d3caf
force-pushed
the
andrew/NR-268466-main-validation
branch
from
821cfdc to
fee517d
Compare
d3caf
commented
Sep 10, 2024
|
I think this is nearly ready to merge. We'll need to do some PR's into main to fully test the workflow. Currently, it can be tested by tweaking some of the triggers/if's. I think the only thing remaining to do is determine whether we're ok with the semver bump being dynamically determined by semantic commit messages (as noted above) |
d3caf
requested review from
a team,
josephgregoryii and
mickeyryan42
and removed request for
a team,
josephgregoryii and
mickeyryan42
d3caf
force-pushed
the
andrew/NR-268466-main-validation
branch
from
093d604 to
a28ed39
Compare
mickeyryan42
approved these changes
Sep 11, 2024
d3caf
commented
Sep 11, 2024
d3caf
commented
Sep 11, 2024
josephgregoryii
approved these changes
Sep 11, 2024
| - name: Build & Validate Artifact | ||
| shell: bash | ||
| id: build-validate-artifact | ||
| run: | | ||
| cd utils && yarn build-validate-quickstart-artifact | ||
| cd utils && yarn build-validate-quickstart-artifact ${{ inputs.output-artifact && '--output-artifact' || '' }} |
There was a problem hiding this comment.
silly question, does this actually supply --output-artifact? if inputs.output-artifact is truthy?
in other words, would want a ternary here?
There was a problem hiding this comment.
Fun fact! You can't ternary in gh actions syntax :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.