Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Clean up installPlans field #2535

Merged
merged 5 commits into from
Aug 27, 2024
Merged

Conversation

stevula
Copy link
Contributor

@stevula stevula commented Aug 26, 2024

To be merged after #2530.

  • Removes install plans from install/ directory.
  • Removes deprecated installPlans field from quickstart yaml.
    • Regex used: /installPlans:(\s+)?\n(\s+-.*\n)+/
  • Removes reference to nonexistent "C" datasource (causing validation error).

@stevula stevula changed the title Chore/clean-up-install-ids-field chore: Clean up installPlans field Aug 26, 2024
@stevula stevula changed the title chore: Clean up installPlans field chore: Clean up installPlans field Aug 26, 2024
@stevula stevula force-pushed the lucia/NR-103912-remove-install-plan-references branch from b46ff3a to 5e5dd78 Compare August 26, 2024 21:40
@stevula stevula force-pushed the chore/clean-up-install-ids-field branch from af6693e to 1c33503 Compare August 26, 2024 21:48
Base automatically changed from lucia/NR-103912-remove-install-plan-references to release August 27, 2024 20:30
@stevula stevula marked this pull request as ready for review August 27, 2024 20:31
Copy link
Contributor

@aswanson-nr aswanson-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good!

@stevula stevula merged commit fcad46f into release Aug 27, 2024
14 of 15 checks passed
@stevula stevula deleted the chore/clean-up-install-ids-field branch August 27, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants