Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Updated vertx documenation link for data source and quickstart #2410

Merged
merged 3 commits into from
May 16, 2024
Merged

fix: Updated vertx documenation link for data source and quickstart #2410

merged 3 commits into from
May 16, 2024

Conversation

gsidhwani-nr
Copy link
Contributor

Summary

fix: Updated vertx documenation links for data source and quickstart

Pre merge checklist

  • [X ] Did you check you NRQL syntax? - Does it work?
  • [X ] Did you include a Data source and Documentation reference?
  • [X ] Are all documentation links publicly accessible?
  • [ X] Did you check your descriptive content for voice and tone?
  • [X ] Did you check your descriptive content for spelling and grammar errors?
  • Did you review your content with a subject matter expert? (e.g. a Browser agent quickstart is reviewed with a member of the Browser Agent team)

Dashboards

  • Does the PR contain a screenshot for each of your dashboards?
  • Do your screenshots show data?
  • Has the sanitization script been run on each dashboard?

Alerts

  • Did you check that your alerts actually work?

@CLAassistant
Copy link

CLAassistant commented May 14, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

sjyothi54
sjyothi54 approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@sjyothi54 sjyothi54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

RamanaReddy8801
RamanaReddy8801 approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@RamanaReddy8801 RamanaReddy8801 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pkudikyala
pkudikyala approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@pkudikyala pkudikyala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sarahkitten sarahkitten merged commit 79f18d4 into newrelic:release May 16, 2024
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjyothi54 sjyothi54 sjyothi54 approved these changes

@pkudikyala pkudikyala pkudikyala approved these changes

@RamanaReddy8801 RamanaReddy8801 RamanaReddy8801 approved these changes

@seemantk seemantk Awaiting requested review from seemantk

@rahulbasu-nr rahulbasu-nr Awaiting requested review from rahulbasu-nr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@gsidhwani-nr @CLAassistant @sjyothi54 @pkudikyala @RamanaReddy8801 @sarahkitten @zstix