Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated NR1_addData and NR1_sys keywords for quickstarts #2398

Merged
merged 6 commits into from
May 7, 2024
Merged

Updated NR1_addData and NR1_sys keywords for quickstarts #2398

merged 6 commits into from
May 7, 2024

Conversation

RamanaReddy8801
Copy link
Contributor

Ticket: https://new-relic.atlassian.net/browse/NR-265187
Description: Updated NR1_addData and NR1_sys keywords for quickstarts

Pre merge checklist

  • Did you check you NRQL syntax? - Does it work?
  • Did you include a Data source and Documentation reference?
  • Are all documentation links publicly accessible?
  • Did you check your descriptive content for voice and tone?
  • Did you check your descriptive content for spelling and grammar errors?
  • Did you review your content with a subject matter expert? (e.g. a Browser agent quickstart is reviewed with a member of the Browser Agent team)

Dashboards

  • Does the PR contain a screenshot for each of your dashboards?
  • Do your screenshots show data?
  • Has the sanitization script been run on each dashboard?

Alerts

  • Did you check that your alerts actually work?

@RamanaReddy8801 RamanaReddy8801 changed the title Nr 265187 Updated NR1_addData and NR1_sys keywords for quickstarts May 3, 2024
@sjyothi54 sjyothi54 added the Tara Submitted by a team member from Tara team (Previously CXPUI team) in HYD label May 6, 2024
pkudikyala
pkudikyala approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@pkudikyala pkudikyala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

mdumpati
mdumpati approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@mdumpati mdumpati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pkudikyala pkudikyala merged commit 4c4b258 into newrelic:release May 7, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkudikyala pkudikyala pkudikyala approved these changes

@mdumpati mdumpati mdumpati approved these changes

@seemantk seemantk Awaiting requested review from seemantk

@rahulbasu-nr rahulbasu-nr Awaiting requested review from rahulbasu-nr

Assignees
No one assigned
Labels
Tara Submitted by a team member from Tara team (Previously CXPUI team) in HYD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RamanaReddy8801 @mdumpati @pkudikyala @sjyothi54