Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Joseph/awsstoragelens #2387

Merged
merged 11 commits into from
May 7, 2024
Merged

Joseph/awsstoragelens #2387

merged 11 commits into from
May 7, 2024

Conversation

jcountsNR
Copy link
Contributor

@jcountsNR jcountsNR commented Apr 29, 2024

Summary

Dashboard for storagelens. This data comes in via cloudwatch metrics, so the integration is already in place.

Pre merge checklist

  • Did you check you NRQL syntax? - Does it work?
  • Did you include a Data source and Documentation reference?
  • Are all documentation links publicly accessible?
  • Did you check your descriptive content for voice and tone?
  • Did you check your descriptive content for spelling and grammar errors?
  • Did you review your content with a subject matter expert? (e.g. a Browser agent quickstart is reviewed with a member of the Browser Agent team)

Dashboards

  • Does the PR contain a screenshot for each of your dashboards?
  • Do your screenshots show data?
  • Has the sanitization script been run on each dashboard?

Alerts

  • Did you check that your alerts actually work?

Copy link
Contributor

@pkudikyala pkudikyala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove the SINCE condition in each query, if it is not required.

@jcountsNR jcountsNR requested a review from rahulbasu-nr as a code owner May 6, 2024 15:43
@jcountsNR
Copy link
Contributor Author

Could you remove the SINCE condition in each query, if it is not required.

The 'SINCE' in this case is actually crucial. These metrics come in only once per day, so the query needs to be exactly 1 day unless they are timeseries, then they need to be a few days grouped by 1 day.

@pkudikyala
Copy link
Contributor

Could you remove the SINCE condition in each query, if it is not required.

The 'SINCE' in this case is actually crucial. These metrics come in only once per day, so the query needs to be exactly 1 day unless they are timeseries, then they need to be a few days grouped by 1 day.

Okay, thanks for the clarification.

Copy link
Contributor

@pkudikyala pkudikyala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@RamanaReddy8801 RamanaReddy8801 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pkudikyala pkudikyala merged commit 57e1e36 into release May 7, 2024
15 checks passed
@pkudikyala pkudikyala deleted the joseph/awsstoragelens branch May 7, 2024 15:10
@MichelLosier MichelLosier mentioned this pull request Jun 6, 2024
10 tasks
@MichelLosier MichelLosier restored the joseph/awsstoragelens branch June 6, 2024 18:04
MichelLosier pushed a commit that referenced this pull request Jun 6, 2024
This was referenced Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants