-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Joseph/awsstoragelens #2387
Joseph/awsstoragelens #2387
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you remove the SINCE condition in each query, if it is not required.
The 'SINCE' in this case is actually crucial. These metrics come in only once per day, so the query needs to be exactly 1 day unless they are timeseries, then they need to be a few days grouped by 1 day. |
Okay, thanks for the clarification. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary
Dashboard for storagelens. This data comes in via cloudwatch metrics, so the integration is already in place.
Pre merge checklist
Dashboards
Alerts