Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NVML Quickstart #2379

Merged
merged 5 commits into from
May 16, 2024
Merged

NVML Quickstart #2379

merged 5 commits into from
May 16, 2024

Conversation

RamanaReddy8801
Copy link
Contributor

Ticket: https://new-relic.atlassian.net/browse/NR-258991
Description: Created new NVML quickstart

Summary

A concise description of the changes being introduced. Please review the pre-merge checklist section to validate this pull request is ready for review and merge. If it is not ready, please mark the pull request as a draft.

The owners of this repo are not experts in the subject matter of the quickstarts. We review for the quickstart to be functional and for security risks. If you are seeking feedback on the content of the quickstart, please seek out a subject matter expert. If you are not an internal NR contributor, we can do our best to connect you with a content reviewer.

Pre merge checklist

  • Did you check you NRQL syntax? - Does it work?
  • Did you include a Data source and Documentation reference?
  • Are all documentation links publicly accessible?
  • Did you check your descriptive content for voice and tone?
  • Did you check your descriptive content for spelling and grammar errors?
  • Did you review your content with a subject matter expert? (e.g. a Browser agent quickstart is reviewed with a member of the Browser Agent team)

Dashboards

  • Does the PR contain a screenshot for each of your dashboards?
  • Do your screenshots show data?
  • Has the sanitization script been run on each dashboard?

Alerts

  • Did you check that your alerts actually work?

@CLAassistant
Copy link

CLAassistant commented Apr 23, 2024

CLA assistant check
All committers have signed the CLA.

@RamanaReddy8801 RamanaReddy8801 marked this pull request as draft April 23, 2024 10:36
@RamanaReddy8801 RamanaReddy8801 added new-quickstart Tara Submitted by a team member from Tara team (Previously CXPUI team) in HYD awaiting docs labels Apr 23, 2024
Copy link

Old PRs will be closed after 30 days of inactivity. This PR has been quiet for 14 days and is being marked as stale. Reply here to keep this PR open.

@github-actions github-actions bot added the stale label May 10, 2024
@RamanaReddy8801 RamanaReddy8801 marked this pull request as ready for review May 14, 2024 03:52
Copy link
Contributor

@sjyothi54 sjyothi54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RamanaReddy8801 Change the nvml logo to nvidia official logo and work on requested changes

@github-actions github-actions bot removed the stale label May 15, 2024
@RamanaReddy8801 RamanaReddy8801 requested a review from sjyothi54 May 15, 2024 04:11
Copy link
Contributor

@sjyothi54 sjyothi54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Contributor

@pkudikyala pkudikyala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sarahkitten sarahkitten merged commit 734e912 into newrelic:release May 16, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting docs new-quickstart Tara Submitted by a team member from Tara team (Previously CXPUI team) in HYD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants