Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sidekiq-prometheus): Added a quickstart for Sidekiq Prometheus m… #2366

Merged
merged 8 commits into from
Apr 25, 2024

Conversation

jospdeleon
Copy link
Contributor

…etrics

Summary

A quickstart dashboard to monitor Sidekiq Prometheus metrics. It uses a third-party sidekiq prometheus exporter that exposes a '/metrics' endpoint which is then scraped by the New Relic Prometheus Agent.

The owners of this repo are not experts in the subject matter of the quickstarts. We review for the quickstart to be functional and for security risks. If you are seeking feedback on the content of the quickstart, please seek out a subject matter expert. If you are not an internal NR contributor, we can do our best to connect you with a content reviewer.

Pre merge checklist

  • Did you check you NRQL syntax? - Does it work?
  • Did you include a Data source and Documentation reference?
  • Are all documentation links publicly accessible?
  • Did you check your descriptive content for voice and tone?
  • Did you check your descriptive content for spelling and grammar errors?
  • Did you review your content with a subject matter expert? (e.g. a Browser agent quickstart is reviewed with a member of the Browser Agent team)

Dashboards

  • Does the PR contain a screenshot for each of your dashboards?
  • Do your screenshots show data?
  • Has the sanitization script been run on each dashboard?

Alerts

  • N/A - Did you check that your alerts actually work?

@CLAassistant
Copy link

CLAassistant commented Apr 11, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@RamanaReddy8801 RamanaReddy8801 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

sjyothi54
sjyothi54 previously approved these changes Apr 16, 2024
Copy link
Contributor

@sjyothi54 sjyothi54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@d3caf d3caf dismissed stale reviews from RamanaReddy8801 and sjyothi54 via 7a1670d April 25, 2024 16:41
@d3caf d3caf merged commit 62d426c into newrelic:release Apr 25, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants