-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added onepane-dashboards #2361
Conversation
updated: summary of onepane
The PR checks have run and found the following warnings:
Reference the Contributing Docs for Dashboards for more information. |
The PR checks have run and found the following warnings:
Reference the Contributing Docs for Dashboards for more information. |
The PR checks have run and found the following warnings:
Reference the Contributing Docs for Dashboards for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sajosam , I left a review for a few changes that are outstanding. Please take a look when you get a chance.
|
||
summary: By correlating deployment change and infrastructure change from OnePane with New Relic, you can enable faster root cause identification for the incidents. | ||
summary: Onepane is an GenAI tool that helps you faster incident resolution with automated Root Cause Analysis. It uses data from New Relic, Cloud, and your DevOps stack to spot changes, events, and incidents. This means you can resolve incidents quicker and cut down your average resolution time (MTTR). | ||
|
||
level: Verified | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Somewhere in here you will need to reference the dashboard and the data sources so that it is related to this quickstart.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jcountsNR, we are confused on how to add a reference to the data source while rewriting the summary to make it shorter. Any examples or documentation would be helpful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you check the IO catalog and glance over the individual tiles tiles you should see what I was referring to. The text displayed there comes from the summary field. You can see the difference between .NET core
and .NET
as a good example. If it's too long it gets truncated and doesn't help understand what it is in a glance.
I would write something like 'Integrate your OnePane infrastructure with New Relic for key observability and root cause analysis` , or something short and simple.
quickstarts/onepane/config.yml
Outdated
|
||
summary: By correlating deployment change and infrastructure change from OnePane with New Relic, you can enable faster root cause identification for the incidents. | ||
summary: Onepane is an GenAI tool that helps you faster incident resolution with automated Root Cause Analysis. It uses data from New Relic, Cloud, and your DevOps stack to spot changes, events, and incidents. This means you can resolve incidents quicker and cut down your average resolution time (MTTR). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually prefer the other summary here. This one will not fit in the marketplace tile, so it will end up trunkated to just the first few words.
add newrelic partner tag Co-authored-by: Joseph Counts <[email protected]>
Hi @jcountsNR The dashboard has been renamed and summary has been updated. Can you review it and let me know if any further changes are needed? |
Co-authored-by: Joseph Counts <[email protected]>
Hi @jcountsNR We have updated the PR. Could you please review it and let me know if any further changes are needed? |
The PR checks have run and found the following warnings:
Reference the Contributing Docs for Dashboards for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sajosam Please make this requested changes
Thank you for your feedback, @sjyothi54 . I have updated the PR with the NR1_addData keyword as requested. The other changes you mentioned were already done in my previous commit. Could you please verify these changes? |
Hi @sajosam The changes you made are correct, but you also need to add the |
Hi @sjyothi54 Thanks for clarifying! To confirm, we already added the logo.png (Onepane logo) in the previous PR, as you can see in the links below: datasource/onepane/logo.png: https://github.com/newrelic/newrelic-quickstarts/blob/release/data-sources/onepane/logo.png Please let us know if you have any other questions or require further changes. |
@sajosam Thanks for clarification, I will approve from my end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The PR checks have run and found the following warnings:
Reference the Contributing Docs for Dashboards for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The PR checks have run and found the following warnings:
Reference the Contributing Docs for Dashboards for more information. |
390c321
The PR checks have run and found the following warnings:
Reference the Contributing Docs for Dashboards for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks goods
feat: Added onepane-dashboards
updated: summary of onepane
Summary
A concise description of the changes being introduced. Please review the pre-merge checklist section to validate this pull request is ready for review and merge. If it is not ready, please mark the pull request as a draft.
The owners of this repo are not experts in the subject matter of the quickstarts. We review for the quickstart to be functional and for security risks. If you are seeking feedback on the content of the quickstart, please seek out a subject matter expert. If you are not an internal NR contributor, we can do our best to connect you with a content reviewer.
Pre merge checklist
Dashboards