Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added onepane-dashboards #2361

Merged
merged 19 commits into from
May 9, 2024
Merged

Conversation

sajosam
Copy link
Contributor

@sajosam sajosam commented Apr 9, 2024

updated: summary of onepane

Summary

A concise description of the changes being introduced. Please review the pre-merge checklist section to validate this pull request is ready for review and merge. If it is not ready, please mark the pull request as a draft.

The owners of this repo are not experts in the subject matter of the quickstarts. We review for the quickstart to be functional and for security risks. If you are seeking feedback on the content of the quickstart, please seek out a subject matter expert. If you are not an internal NR contributor, we can do our best to connect you with a content reviewer.

Pre merge checklist

  • Did you check you NRQL syntax? - Does it work?
  • Did you include a Data source and Documentation reference?
  • Are all documentation links publicly accessible?
  • Did you check your descriptive content for voice and tone?
  • Did you check your descriptive content for spelling and grammar errors?
  • Did you review your content with a subject matter expert? (e.g. a Browser agent quickstart is reviewed with a member of the Browser Agent team)

Dashboards

  • Does the PR contain a screenshot for each of your dashboards?
  • Do your screenshots show data?
  • Has the sanitization script been run on each dashboard?

updated: summary of onepane
@CLAassistant
Copy link

CLAassistant commented Apr 9, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

The PR checks have run and found the following warnings:

Warning Filepath
"guid" should not be used dashboards/onepane/onepane.json
"entityGuid" should not be used dashboards/onepane/onepane.json

Reference the Contributing Docs for Dashboards for more information.

Copy link

The PR checks have run and found the following warnings:

Warning Filepath
"guid" should not be used dashboards/onepane/onepane.json
"entityGuid" should not be used dashboards/onepane/onepane.json

Reference the Contributing Docs for Dashboards for more information.

Copy link

The PR checks have run and found the following warnings:

Warning Filepath
"guid" should not be used dashboards/onepane/onepane.json
"entityGuid" should not be used dashboards/onepane/onepane.json

Reference the Contributing Docs for Dashboards for more information.

Copy link
Contributor

@jcountsNR jcountsNR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sajosam , I left a review for a few changes that are outstanding. Please take a look when you get a chance.


summary: By correlating deployment change and infrastructure change from OnePane with New Relic, you can enable faster root cause identification for the incidents.
summary: Onepane is an GenAI tool that helps you faster incident resolution with automated Root Cause Analysis. It uses data from New Relic, Cloud, and your DevOps stack to spot changes, events, and incidents. This means you can resolve incidents quicker and cut down your average resolution time (MTTR).

level: Verified

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somewhere in here you will need to reference the dashboard and the data sources so that it is related to this quickstart.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jcountsNR, we are confused on how to add a reference to the data source while rewriting the summary to make it shorter. Any examples or documentation would be helpful.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you check the IO catalog and glance over the individual tiles tiles you should see what I was referring to. The text displayed there comes from the summary field. You can see the difference between .NET core and .NET as a good example. If it's too long it gets truncated and doesn't help understand what it is in a glance.

I would write something like 'Integrate your OnePane infrastructure with New Relic for key observability and root cause analysis` , or something short and simple.


summary: By correlating deployment change and infrastructure change from OnePane with New Relic, you can enable faster root cause identification for the incidents.
summary: Onepane is an GenAI tool that helps you faster incident resolution with automated Root Cause Analysis. It uses data from New Relic, Cloud, and your DevOps stack to spot changes, events, and incidents. This means you can resolve incidents quicker and cut down your average resolution time (MTTR).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually prefer the other summary here. This one will not fit in the marketplace tile, so it will end up trunkated to just the first few words.

@sajosam
Copy link
Contributor Author

sajosam commented Apr 20, 2024

Hi @jcountsNR

The dashboard has been renamed and summary has been updated. Can you review it and let me know if any further changes are needed?

@sajosam
Copy link
Contributor Author

sajosam commented Apr 23, 2024

Hi @jcountsNR

We have updated the PR. Could you please review it and let me know if any further changes are needed?

Copy link

The PR checks have run and found the following warnings:

Warning Filepath
"guid" should not be used dashboards/onepane/onepane.json
"entityGuid" should not be used dashboards/onepane/onepane.json

Reference the Contributing Docs for Dashboards for more information.

jcountsNR
jcountsNR previously approved these changes Apr 24, 2024
Copy link
Contributor

@jcountsNR jcountsNR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@jcountsNR jcountsNR removed the request for review from rahulbasu-nr April 24, 2024 14:11
Copy link
Contributor

@sjyothi54 sjyothi54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sajosam Please make this requested changes

@sajosam
Copy link
Contributor Author

sajosam commented Apr 26, 2024

Thank you for your feedback, @sjyothi54 . I have updated the PR with the NR1_addData keyword as requested. The other changes you mentioned were already done in my previous commit. Could you please verify these changes?

@sjyothi54
Copy link
Contributor

Thank you for your feedback, @sjyothi54 . I have updated the PR with the NR1_addData keyword as requested. The other changes you mentioned were already done in my previous commit. Could you please verify these changes?

Hi @sajosam The changes you made are correct, but you also need to add the logo.png(logo of onepane in png format) file to both the data-sources/onepane and quickstarts/onepane folders.

@sajosam
Copy link
Contributor Author

sajosam commented May 1, 2024

Hi @sjyothi54

Thanks for clarifying! To confirm, we already added the logo.png (Onepane logo) in the previous PR, as you can see in the links below:

datasource/onepane/logo.png: https://github.com/newrelic/newrelic-quickstarts/blob/release/data-sources/onepane/logo.png
qwickstart/onepane/logo.png: https://github.com/newrelic/newrelic-quickstarts/blob/release/quickstarts/onepane/logo.png

Please let us know if you have any other questions or require further changes.

@sjyothi54
Copy link
Contributor

Hi @sjyothi54

Thanks for clarifying! To confirm, we already added the logo.png (Onepane logo) in the previous PR, as you can see in the links below:

datasource/onepane/logo.png: https://github.com/newrelic/newrelic-quickstarts/blob/release/data-sources/onepane/logo.png qwickstart/onepane/logo.png: https://github.com/newrelic/newrelic-quickstarts/blob/release/quickstarts/onepane/logo.png

Please let us know if you have any other questions or require further changes.

@sajosam Thanks for clarification, I will approve from my end

sjyothi54
sjyothi54 previously approved these changes May 2, 2024
Copy link
Contributor

@sjyothi54 sjyothi54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

github-actions bot commented May 2, 2024

The PR checks have run and found the following warnings:

Warning Filepath
"guid" should not be used dashboards/onepane/onepane.json
"entityGuid" should not be used dashboards/onepane/onepane.json

Reference the Contributing Docs for Dashboards for more information.

pkudikyala
pkudikyala previously approved these changes May 2, 2024
Copy link
Contributor

@pkudikyala pkudikyala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

seemantk
seemantk previously approved these changes May 2, 2024
Copy link

github-actions bot commented May 7, 2024

The PR checks have run and found the following warnings:

Warning Filepath
"guid" should not be used dashboards/onepane/onepane.json
"entityGuid" should not be used dashboards/onepane/onepane.json

Reference the Contributing Docs for Dashboards for more information.

@sajosam sajosam dismissed stale reviews from pkudikyala, sjyothi54, and seemantk via 390c321 May 8, 2024 04:40
Copy link

github-actions bot commented May 8, 2024

The PR checks have run and found the following warnings:

Warning Filepath
"guid" should not be used dashboards/onepane/onepane.json
"entityGuid" should not be used dashboards/onepane/onepane.json

Reference the Contributing Docs for Dashboards for more information.

Copy link
Contributor

@RamanaReddy8801 RamanaReddy8801 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@RamanaReddy8801 RamanaReddy8801 requested a review from sjyothi54 May 9, 2024 11:07
Copy link
Contributor

@sjyothi54 sjyothi54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks goods

@sjyothi54 sjyothi54 merged commit a5d194e into newrelic:release May 9, 2024
12 checks passed
@MichelLosier MichelLosier mentioned this pull request Jun 6, 2024
10 tasks
MichelLosier pushed a commit that referenced this pull request Jun 6, 2024
feat: Added onepane-dashboards
This was referenced Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants