Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat : Added Quickstarts for vert.x eventbus and extensions - New Relic Labs #2322

Merged
merged 6 commits into from
Mar 21, 2024

Conversation

gsidhwani-nr
Copy link
Contributor

…ic Labs

Summary

Added Quickstarts for vert.x eventbus and extensions - New Relic Labs
Pre-Existing Java Dashboards, Alerts are included in Quickstart.

The owners of this repo are not experts in the subject matter of the quickstarts. We review for the quickstart to be functional and for security risks. If you are seeking feedback on the content of the quickstart, please seek out a subject matter expert. If you are not an internal NR contributor, we can do our best to connect you with a content reviewer.

Pre merge checklist

  • [X ] Did you check you NRQL syntax? - Does it work?
  • Did you include a Data source and Documentation reference?
  • Are all documentation links publicly accessible?
  • Did you check your descriptive content for voice and tone?
  • [X ] Did you check your descriptive content for spelling and grammar errors?
  • Did you review your content with a subject matter expert? (e.g. a Browser agent quickstart is reviewed with a member of the Browser Agent team)

Dashboards

  • Does the PR contain a screenshot for each of your dashboards?
  • Do your screenshots show data?
  • Has the sanitization script been run on each dashboard?

Alerts

  • Did you check that your alerts actually work?

Copy link
Contributor

@pkudikyala pkudikyala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @gsidhwani-nr ,
Could you make the review changes.

quickstarts/java/vertx-eventbus/config.yml Outdated Show resolved Hide resolved
quickstarts/java/vertx-extensions/config.yml Outdated Show resolved Hide resolved
@gsidhwani-nr
Copy link
Contributor Author

The requested changes have been committed.

Copy link
Contributor

@pkudikyala pkudikyala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pkudikyala pkudikyala merged commit c2a9b6d into newrelic:main Mar 21, 2024
12 checks passed
josephgregoryii added a commit that referenced this pull request Mar 22, 2024
This reverts commit c2a9b6d, reversing
changes made to 9c2a1c1.
@josephgregoryii josephgregoryii mentioned this pull request Mar 22, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants