Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate GCP dashboards from Metric to Samples #2292

Merged
merged 20 commits into from
Mar 7, 2024

Conversation

jlegoff
Copy link
Contributor

@jlegoff jlegoff commented Feb 21, 2024

Summary

This PR converts all GCP dashboards from Metric to Samples. This is because the GCP integrations send samples natively and this data will not be converted to dimensional metrics.

Pre merge checklist

  • Did you check you NRQL syntax? - Does it work?
  • Did you include a Data source and Documentation reference?
  • Are all documentation links publicly accessible?
  • Did you check your descriptive content for voice and tone?
  • Did you check your descriptive content for spelling and grammar errors?
  • Did you review your content with a subject matter expert? (e.g. a Browser agent quickstart is reviewed with a member of the Browser Agent team)

Dashboards

  • Does the PR contain a screenshot for each of your dashboards?
  • Do your screenshots show data?
  • Has the sanitization script been run on each dashboard?

Alerts

  • Did you check that your alerts actually work?

@jlegoff jlegoff requested a review from seemantk as a code owner February 21, 2024 14:42
Copy link
Contributor

@mdumpati mdumpati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdumpati mdumpati merged commit 41b0880 into newrelic:release Mar 7, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants