Update Alert class to handle nrql validation #2196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephgregoryii
requested review from
a team,
d3caf and
mickeyryan42
and removed request for
a team
zstix
approved these changes
Jan 10, 2024
Co-authored-by: Zack Stickles <[email protected]>
Co-authored-by: Zack Stickles <[email protected]>
Co-authored-by: Zack Stickles <[email protected]>
Co-authored-by: Zack Stickles <[email protected]>
* Remove pop in list
zstix
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR stems from handling alert policy error while installing alerts in our UI.
We found that alert conditions that contain a nrql query with
TIMESERIESfail an installation after ithits our database.
This is a supplementary PR #2190 so we can have a more automated process when verifying alert conditions in PRs.
Testing
Our workflows that validate quickstarts will fail during checks.
Testing PR: #2197
Link to validation failure + logs: https://github.com/newrelic/newrelic-quickstarts/actions/runs/7468258398/job/20323336084