Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Product Partnerships] Added Amazon Backup #2180

Merged
merged 7 commits into from
Jan 16, 2024
Merged

[Product Partnerships] Added Amazon Backup #2180

merged 7 commits into from
Jan 16, 2024

Conversation

rahul188
Copy link
Contributor

@rahul188 rahul188 commented Jan 2, 2024

Pre merge checklist

  • Did you check you NRQL syntax? - Does it work?
  • Did you include a Data source and Documentation reference?
  • Are all documentation links publicly accessible?
  • Did you check your descriptive content for voice and tone?
  • Did you check your descriptive content for spelling and grammar errors?
  • Did you review your content with a subject matter expert? (e.g. a Browser agent quickstart is reviewed with a member of the Browser Agent team)

Dashboards

  • Does the PR contain a screenshot for each of your dashboards?
  • Do your screenshots show data?
  • Has the sanitization script been run on each dashboard?

Alerts

  • Did you check that your alerts actually work?

@rahul188 rahul188 requested a review from seemantk as a code owner January 2, 2024 13:38
Copy link

github-actions bot commented Jan 2, 2024

The PR checks have run and found the following warnings:

Warning Filepath
"permissions" field should not be used dashboards/amazon-backup/amazon-backup.json

Reference the Contributing Docs for Dashboards for more information.

Copy link
Contributor

@sarahkitten sarahkitten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like validation is failing because the alert policy file path has a typo (amzon-backup)

@rahul188
Copy link
Contributor Author

Looks like validation is failing because the alert policy file path has a typo (amzon-backup)

Thanks @sarahkitten, I made the required changes.

@newrelic newrelic deleted a comment from github-actions bot Jan 10, 2024
@newrelic newrelic deleted a comment from github-actions bot Jan 10, 2024
@newrelic newrelic deleted a comment from github-actions bot Jan 10, 2024
@zstix zstix merged commit c4f5a37 into newrelic:release Jan 16, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants