Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Product Partnerships] Added AWS IOT Twinmaker #2175

Merged
merged 5 commits into from
Jan 16, 2024
Merged

[Product Partnerships] Added AWS IOT Twinmaker #2175

merged 5 commits into from
Jan 16, 2024

Conversation

rahul188
Copy link
Contributor

Pre merge checklist

  • Did you check you NRQL syntax? - Does it work?
  • Did you include a Data source and Documentation reference?
  • Are all documentation links publicly accessible?
  • Did you check your descriptive content for voice and tone?
  • Did you check your descriptive content for spelling and grammar errors?
  • Did you review your content with a subject matter expert? (e.g. a Browser agent quickstart is reviewed with a member of the Browser Agent team)

Dashboards

  • Does the PR contain a screenshot for each of your dashboards?
  • Do your screenshots show data?
  • Has the sanitization script been run on each dashboard?

Alerts

  • Did you check that your alerts actually work?

@rahul188 rahul188 requested a review from seemantk as a code owner December 21, 2023 11:01
sarahkitten
sarahkitten suggested changes Jan 9, 2024
View reviewed changes
quickstarts/aws/aws-iot-twinmaker/config.yml Outdated
- aws iot twinmaker
- twinmaker
dashboards:
- aws-twinmaker
Copy link
Contributor

@sarahkitten sarahkitten Jan 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like validation is failing because this dashboard name doesn't match the dashboard created in this PR (aws-iot-twinmaker).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sarahkitten, I made the required changes.

quickstarts/aws/aws-iot-twinmaker/config.yml Outdated
dataSourceIds:
- amazon-cloudwatch-metric-streams
alertPolicies:
- aws-twinmaker
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same problem here as above

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sarahkitten, I made the required changes.

@zstix zstix merged commit 5fa904c into newrelic:release Jan 16, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarahkitten sarahkitten sarahkitten approved these changes

@zstix zstix zstix approved these changes

@seemantk seemantk Awaiting requested review from seemantk

Assignees
No one assigned
Labels
waiting on contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rahul188 @zstix @sarahkitten