[Product Partnerships] Added AWS VPN Entity #2168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution, our team will be reviewing this shortly, please be available for any follow up questions or code review feedback! |
|
Old PRs will be closed after 30 days of inactivity. This PR has been quiet for 14 days and is being marked as stale. Reply here to keep this PR open. |
sarahkitten
approved these changes
Jan 9, 2024
sarahkitten
suggested changes
Jan 9, 2024
quickstarts/aws/aws-vpn/config.yml
Outdated
| dataSourceIds: | ||
| - amazon-cloudwatch-metric-streams | ||
| alertPolicies: | ||
| - aws-vpn |
There was a problem hiding this comment.
It looks like validation is failing because this alert policy doesn't exist
There was a problem hiding this comment.
Thanks @sarahkitten, I made the required changes.
zstix
approved these changes
Jan 16, 2024
sarahkitten
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A concise description of the changes being introduced. Please review the pre-merge checklist section to validate this pull request is ready for review and merge. If it is not ready, please mark the pull request as a draft.
The owners of this repo are not experts in the subject matter of the quickstarts. We review for the quickstart to be functional and for security risks. If you are seeking feedback on the content of the quickstart, please seek out a subject matter expert. If you are not an internal NR contributor, we can do our best to connect you with a content reviewer.
Pre merge checklist
Dashboards
Alerts