Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NR-155179 Linked GCP dashboards to quickstart #2164

Closed
wants to merge 3 commits into from
Closed

NR-155179 Linked GCP dashboards to quickstart #2164

wants to merge 3 commits into from

Conversation

rajut-xrg
Copy link
Contributor

@rajut-xrg rajut-xrg commented Dec 13, 2023 •
edited
Loading

Summary

This PR consists of changes related to GCP dashboards where these dashboards are linked to Quickstart.

This had to merge once The PR-2156 is merged

Pre merge checklist

  • Did you check you NRQL syntax? - Does it work?
  • Did you include a Data source and Documentation reference?
  • Are all documentation links publicly accessible?
  • Did you check your descriptive content for voice and tone?
  • Did you check your descriptive content for spelling and grammar errors?
  • Did you review your content with a subject matter expert? (e.g. a Browser agent quickstart is reviewed with a member of the Browser Agent team)

Dashboards

  • Does the PR contain a screenshot for each of your dashboards?
  • Do your screenshots show data?
  • Has the sanitization script been run on each dashboard?

Alerts

  • Did you check that your alerts actually work?

@rajut-xrg rajut-xrg requested a review from seemantk as a code owner December 13, 2023 08:57
@github-actions GitHub Actions
Copy link

Thank you for your contribution, our team will be reviewing this shortly, please be available for any follow up questions or code review feedback!

aswanson-nr
aswanson-nr reviewed Dec 14, 2023
View reviewed changes
Copy link
Contributor

@aswanson-nr aswanson-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saw 2 things to clean up, but this looks good to me!

quickstarts/gcp/gcp-redis/config.yml Outdated Show resolved Hide resolved
quickstarts/gcp/google-cloud-bigtable/config.yml Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Old PRs will be closed after 30 days of inactivity. This PR has been quiet for 14 days and is being marked as stale. Reply here to keep this PR open.

@github-actions github-actions bot added the stale label Dec 30, 2023
@aswanson-nr
Copy link
Contributor

not stale!

@aswanson-nr aswanson-nr removed the stale label Jan 3, 2024
@sarahkitten sarahkitten changed the base branch from main to release January 11, 2024 17:46
@github-actions GitHub Actions
Copy link

Old PRs will be closed after 30 days of inactivity. This PR has been quiet for 14 days and is being marked as stale. Reply here to keep this PR open.

@github-actions github-actions bot added the stale label Jan 26, 2024
@aswanson-nr
Copy link
Contributor

Not stale!

@aswanson-nr aswanson-nr removed the stale label Jan 26, 2024
@tmarchand-nr tmarchand-nr mentioned this pull request Jan 30, 2024
Merged
10 tasks
@tmarchand-nr
Copy link
Contributor

This PR can be closed and is replaced by #2262

@d3caf d3caf closed this Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seemantk seemantk Awaiting requested review from seemantk

@aswanson-nr aswanson-nr Awaiting requested review from aswanson-nr

Assignees
No one assigned
Labels
new-quickstart
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rajut-xrg @aswanson-nr @tmarchand-nr @d3caf