Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the language agent keyword to the nodejs dashboard using Quickstarts. #2155

Merged
merged 6 commits into from
Jan 10, 2024

Conversation

pkudikyala
Copy link
Contributor

@pkudikyala pkudikyala commented Dec 1, 2023

Jira Ticket: https://new-relic.atlassian.net/browse/NR-183276
Description: I added the language agent keyword to the nodejs dashboard using Quickstarts.

Summary

A concise description of the changes being introduced. Please review the pre-merge checklist section to validate this pull request is ready for review and merge. If it is not ready, please mark the pull request as a draft.

The owners of this repo are not experts in the subject matter of the quickstarts. We review for the quickstart to be functional and for security risks. If you are seeking feedback on the content of the quickstart, please seek out a subject matter expert. If you are not an internal NR contributor, we can do our best to connect you with a content reviewer.

Pre merge checklist

  • Did you check you NRQL syntax? - Does it work?
  • Did you include a Data source and Documentation reference?
  • Are all documentation links publicly accessible?
  • Did you check your descriptive content for voice and tone?
  • Did you check your descriptive content for spelling and grammar errors?
  • Did you review your content with a subject matter expert? (e.g. a Browser agent quickstart is reviewed with a member of the Browser Agent team)

Dashboards

  • Does the PR contain a screenshot for each of your dashboards?
  • Do your screenshots show data?
  • Has the sanitization script been run on each dashboard?

Alerts

  • Did you check that your alerts actually work?

Copy link

github-actions bot commented Dec 1, 2023

Thank you for your contribution, our team will be reviewing this shortly, please be available for any follow up questions or code review feedback!

@pkudikyala pkudikyala changed the title Added the language agent keyword to express quickstart. Added the language agent keyword to the nodejs dashboard using Quickstarts. Dec 4, 2023
@pkudikyala pkudikyala requested a review from seemantk as a code owner December 13, 2023 05:11
Copy link

Old PRs will be closed after 30 days of inactivity. This PR has been quiet for 14 days and is being marked as stale. Reply here to keep this PR open.

@github-actions github-actions bot added the stale label Dec 28, 2023
@aswanson-nr
Copy link
Contributor

not stale

@aswanson-nr aswanson-nr removed the stale label Jan 3, 2024
sarahkitten
sarahkitten previously approved these changes Jan 9, 2024
@sarahkitten sarahkitten changed the base branch from main to release January 9, 2024 17:57
@sarahkitten sarahkitten dismissed their stale review January 9, 2024 17:57

The base branch was changed.

@aswanson-nr aswanson-nr merged commit bc9dce2 into newrelic:release Jan 10, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants