Update elasticsearch.json #2140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed the `SELECT` clause from: Active Search Latency (ms) Get Requests Latency (ms) Failed Indexing Operations per Node (Filterable) Indexing Latency (ms) Index Refresh Latency (ms) Some of them were dividing UNITS/milliseconds. When the goal is to find the average time of each unit it should be MS/UNITS. Additionally, `host.hostname` was being used for FACET when those metrics resulted in inconsistent data. Switched to using `entity.name` for correct results. `capture()` is used to sanitise node names.
|
Thank you for your contribution, our team will be reviewing this shortly, please be available for any follow up questions or code review feedback! |
mickeyryan42
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed the
SELECTclause from:Active Search Latency (ms)
Get Requests Latency (ms)
Failed Indexing Operations per Node (Filterable)
Indexing Latency (ms)
Index Refresh Latency (ms)
Some of them were dividing UNITS/milliseconds. When the goal is to find the average time of each unit it should be MS/UNITS. Additionally,
host.hostnamewas being used for FACET when those metrics resulted in inconsistent data. Switched to usingentity.namefor correct results.capture()is used to sanitise node names.