Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NVIDIA DCGM - New AI Quickstart #2133

Merged
merged 10 commits into from
Nov 9, 2023
Merged

Conversation

RamanaReddy8801
Copy link
Contributor

Summary

Ticket: https://new-relic.atlassian.net/browse/NR-174994
Description: Created NVIDIA DCGM quickstart.

A concise description of the changes being introduced. Please review the pre-merge checklist section to validate this pull request is ready for review and merge. If it is not ready, please mark the pull request as a draft.

The owners of this repo are not experts in the subject matter of the quickstarts. We review for the quickstart to be functional and for security risks. If you are seeking feedback on the content of the quickstart, please seek out a subject matter expert. If you are not an internal NR contributor, we can do our best to connect you with a content reviewer.

Pre merge checklist

  • Did you check you NRQL syntax? - Does it work?
  • Did you include a Data source and Documentation reference?
  • Are all documentation links publicly accessible?
  • Did you check your descriptive content for voice and tone?
  • Did you check your descriptive content for spelling and grammar errors?
  • Did you review your content with a subject matter expert? (e.g. a Browser agent quickstart is reviewed with a member of the Browser Agent team)

Dashboards

  • Does the PR contain a screenshot for each of your dashboards?
  • Do your screenshots show data?
  • Has the sanitization script been run on each dashboard?

Alerts

  • Did you check that your alerts actually work?

@github-actions
Copy link

Thank you for your contribution, our team will be reviewing this shortly, please be available for any follow up questions or code review feedback!

@RamanaReddy8801 RamanaReddy8801 added Tara Submitted by a team member from Tara team (Previously CXPUI team) in HYD aimlops AI & MLOps labels Oct 31, 2023
@RamanaReddy8801 RamanaReddy8801 marked this pull request as draft October 31, 2023 10:35
@RamanaReddy8801 RamanaReddy8801 marked this pull request as ready for review November 1, 2023 06:10
Copy link
Contributor

@rahulbasu-nr rahulbasu-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make these changes.

alert-policies/nvidia-dcgm/HighTemperature.yml Outdated Show resolved Hide resolved
dashboards/nvidia-dcgm/nvidia-dcgm.json Outdated Show resolved Hide resolved
dashboards/nvidia-dcgm/nvidia-dcgm.json Outdated Show resolved Hide resolved
dashboards/nvidia-dcgm/nvidia-dcgm.json Outdated Show resolved Hide resolved
data-sources/nvidia-dcgm/logo.png Outdated Show resolved Hide resolved
quickstarts/nvidia-dcgm/config.yml Outdated Show resolved Hide resolved
quickstarts/nvidia-dcgm/config.yml Outdated Show resolved Hide resolved
quickstarts/nvidia-dcgm/config.yml Show resolved Hide resolved
quickstarts/nvidia-dcgm/logo.png Outdated Show resolved Hide resolved
Copy link
Contributor

@mickeyryan42 mickeyryan42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, We'll just want to add the keyword i commented separately

rahulbasu-nr
rahulbasu-nr previously approved these changes Nov 8, 2023
Copy link
Contributor

@rahulbasu-nr rahulbasu-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Contributor

@pkosanam pkosanam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@rahulbasu-nr rahulbasu-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@mickeyryan42 mickeyryan42 merged commit 6b0a053 into newrelic:main Nov 9, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aimlops AI & MLOps new-quickstart Tara Submitted by a team member from Tara team (Previously CXPUI team) in HYD
Projects
Development

Successfully merging this pull request may close these issues.

4 participants