Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NR-111177 - Migrate collectd datasource #2099

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

mwu3535
Copy link
Contributor

@mwu3535 mwu3535 commented Oct 4, 2023

Summary

https://issues.newrelic.com/browse/NR-111177
https://source.datanerd.us/nr1-dev-experience/marketplace/pull/547

The owners of this repo are not experts in the subject matter of the quickstarts. We review for the quickstart to be functional and for security risks. If you are seeking feedback on the content of the quickstart, please seek out a subject matter expert. If you are not an internal NR contributor, we can do our best to connect you with a content reviewer.

Pre merge checklist

  • Did you check you NRQL syntax? - Does it work?
  • Did you include a Data source and Documentation reference?
  • Are all documentation links publicly accessible?
  • Did you check your descriptive content for voice and tone?
  • Did you check your descriptive content for spelling and grammar errors?
  • Did you review your content with a subject matter expert? (e.g. a Browser agent quickstart is reviewed with a member of the Browser Agent team)

Dashboards

  • Does the PR contain a screenshot for each of your dashboards?
  • Do your screenshots show data?
  • Has the sanitization script been run on each dashboard?

Alerts

  • Did you check that your alerts actually work?

@github-actions
Copy link

github-actions bot commented Oct 4, 2023

Thank you for your contribution, our team will be reviewing this shortly, please be available for any follow up questions or code review feedback!

@MichelLosier MichelLosier merged commit b6f5df7 into newrelic:main Oct 4, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants