Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Product Partnerships] Added Amazon Transfer Family Entity #2096

Merged
merged 3 commits into from
Oct 13, 2023
Merged

[Product Partnerships] Added Amazon Transfer Family Entity #2096

merged 3 commits into from
Oct 13, 2023

Conversation

rahul188
Copy link
Contributor

@rahul188 rahul188 commented Oct 4, 2023

Pre merge checklist

  • Did you check you NRQL syntax? - Does it work?
  • Did you include a Data source and Documentation reference?
  • Are all documentation links publicly accessible?
  • Did you check your descriptive content for voice and tone?
  • Did you check your descriptive content for spelling and grammar errors?
  • Did you review your content with a subject matter expert? (e.g. a Browser agent quickstart is reviewed with a member of the Browser Agent team)

Dashboards

  • Does the PR contain a screenshot for each of your dashboards?
  • Do your screenshots show data?
  • Has the sanitization script been run on each dashboard?

Alerts

  • Did you check that your alerts actually work?

@rahul188 rahul188 requested a review from seemantk as a code owner October 4, 2023 10:45
@github-actions
Copy link

github-actions bot commented Oct 4, 2023

Thank you for your contribution, our team will be reviewing this shortly, please be available for any follow up questions or code review feedback!

MichelLosier
MichelLosier approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@MichelLosier MichelLosier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just awaiting docs to go live:
https://docs.newrelic.com/docs/infrastructure/amazon-integrations/aws-integrations-list/amazon-transfer-family-monitoring-integration/

@rahul188
Copy link
Contributor Author

@MichelLosier , the docs are live now. can you please take a look & merge the PR.

@aswanson-nr aswanson-nr merged commit d474eee into newrelic:main Oct 13, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caylahamann caylahamann caylahamann approved these changes

@MichelLosier MichelLosier MichelLosier approved these changes

@seemantk seemantk Awaiting requested review from seemantk

Assignees
No one assigned
Labels
awaiting docs new-quickstart
Projects
NR1 Quickstarts Community
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rahul188 @MichelLosier @caylahamann @aswanson-nr @nr-mlosier