Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hologres Matching Engine Quickstart #2079

Merged
merged 10 commits into from
Oct 12, 2023
Merged

Hologres Matching Engine Quickstart #2079

merged 10 commits into from
Oct 12, 2023

Conversation

sjyothi54
Copy link
Contributor

Ticket: https://issues.newrelic.com/browse/NR-164851
Description: Created Hologres Matching Engine Quickstart

Pre merge checklist

  • Did you check you NRQL syntax? - Does it work?
  • Did you include a Data source and Documentation reference?
  • Are all documentation links publicly accessible?
  • Did you check your descriptive content for voice and tone?
  • Did you check your descriptive content for spelling and grammar errors?
  • Did you review your content with a subject matter expert? (e.g. a Browser agent quickstart is reviewed with a member of the Browser Agent team)

Dashboards

  • Does the PR contain a screenshot for each of your dashboards?
  • Do your screenshots show data?
  • Has the sanitization script been run on each dashboard?

Alerts

  • Did you check that your alerts actually work?

@github-actions
Copy link

Thank you for your contribution, our team will be reviewing this shortly, please be available for any follow up questions or code review feedback!

@sjyothi54 sjyothi54 added Tara Submitted by a team member from Tara team (Previously CXPUI team) in HYD aimlops AI & MLOps labels Sep 27, 2023
rahulbasu-nr
rahulbasu-nr suggested changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@rahulbasu-nr rahulbasu-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the changes.

@sjyothi54
Copy link
Contributor Author

Please make the changes.

@rahulbasu-nr I have updated the changes, kindly review it.

rahulbasu-nr
rahulbasu-nr approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@rahulbasu-nr rahulbasu-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

mdumpati
mdumpati approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@mdumpati mdumpati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdumpati mdumpati merged commit 862d173 into newrelic:main Oct 12, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahulbasu-nr rahulbasu-nr rahulbasu-nr approved these changes

@mdumpati mdumpati mdumpati approved these changes

Assignees
No one assigned
Labels
aimlops AI & MLOps new-quickstart Tara Submitted by a team member from Tara team (Previously CXPUI team) in HYD
Projects
NR1 Quickstarts Community
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sjyothi54 @mdumpati @rahulbasu-nr