Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mariadb): Show the mysql config directly #2058

Merged
merged 6 commits into from
Oct 5, 2023

Conversation

NSSPKrishna
Copy link
Member

@NSSPKrishna NSSPKrishna commented Sep 14, 2023

Summary

As part of Shape Up week, we at Virtuoso are aiming to enhance the user experience for MariaDB integration. To achieve this, we are implementing a streamlined process that allows users to directly access the Install flow page, bypassing the intermediary suggestion page.

Pre merge checklist

  • Did you check you NRQL syntax? - Does it work?
  • Did you include a Data source and Documentation reference?
  • Are all documentation links publicly accessible?
  • Did you check your descriptive content for voice and tone?
  • Did you check your descriptive content for spelling and grammar errors?
  • Did you review your content with a subject matter expert? (e.g. a Browser agent quickstart is reviewed with a member of the Browser Agent team)

Dashboards

  • Does the PR contain a screenshot for each of your dashboards?
  • Do your screenshots show data?
  • Has the sanitization script been run on each dashboard?

Alerts

  • Did you check that your alerts actually work?

@github-actions
Copy link

Thank you for your contribution, our team will be reviewing this shortly, please be available for any follow up questions or code review feedback!

@NSSPKrishna NSSPKrishna marked this pull request as ready for review September 14, 2023 09:59
@pkosanam
Copy link
Contributor

pkosanam commented Oct 4, 2023

Hi @NSSPKrishna , as discussed, we are not using mariadb datasource to trigger the installation of mariadb quickstart.
Thank you

@NSSPKrishna
Copy link
Member Author

I have made the necessary changes to the branch. Please review @pkosanam

@pkosanam
Copy link
Contributor

pkosanam commented Oct 5, 2023

Hi @NSSPKrishna , as discussed, mariadb datasource is not hosted. Hence you are seeing the below error while running install framework repository in your local.
Datasource list: https://onenr.io/0kjnp9eB6wo

image

@pkosanam
Copy link
Contributor

pkosanam commented Oct 5, 2023

Also, I have explained you that, when a community datasource(datasource which is hosted on quickstart repository) is displayed on "Add data" page, then we see "Begin installation" button.

Here is an example.

  1. community datasource: langchain
image 2. On clicking on it, we see "Begin installation" button image 3. Only after clicking on it, we will see the installation flow, which was created on marketplace repository image

Hope this description helps.

@NSSPKrishna NSSPKrishna requested a review from pkosanam October 5, 2023 07:26
@MichelLosier MichelLosier merged commit 529626a into newrelic:main Oct 5, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants