Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Product Partnerships]Renamed files for Amazon Sagemaker for Drupal to pick images #2055

Merged
merged 2 commits into from
Sep 20, 2023
Merged

Conversation

aj-NR
Copy link
Contributor

@aj-NR aj-NR commented Sep 13, 2023

Summary

A concise description of the changes being introduced. Please review the pre-merge checklist section to validate this pull request is ready for review and merge. If it is not ready, please mark the pull request as a draft.

The owners of this repo are not experts in the subject matter of the quickstarts. We review for the quickstart to be functional and for security risks. If you are seeking feedback on the content of the quickstart, please seek out a subject matter expert. If you are not an internal NR contributor, we can do our best to connect you with a content reviewer.

Pre merge checklist

  • Did you check you NRQL syntax? - Does it work?
  • Did you include a Data source and Documentation reference?
  • Are all documentation links publicly accessible?
  • Did you check your descriptive content for voice and tone?
  • Did you check your descriptive content for spelling and grammar errors?
  • Did you review your content with a subject matter expert? (e.g. a Browser agent quickstart is reviewed with a member of the Browser Agent team)

Dashboards

  • Does the PR contain a screenshot for each of your dashboards?
  • Do your screenshots show data?
  • Has the sanitization script been run on each dashboard?

Alerts

  • Did you check that your alerts actually work?

@aj-NR aj-NR requested a review from seemantk as a code owner September 13, 2023 08:53
@github-actions
Copy link

Thank you for your contribution, our team will be reviewing this shortly, please be available for any follow up questions or code review feedback!

@aj-NR aj-NR changed the title [Product Partnerships]Renamed files for Drupal to pick images [Product Partnerships]Renamed files for Amazon Sagemaker for Drupal to pick images Sep 13, 2023
@aj-NR aj-NR added aimlops AI & MLOps northstar Created by Project NorthStar labels Sep 13, 2023
Copy link
Contributor

@pkosanam pkosanam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pkosanam pkosanam merged commit b6c9a71 into newrelic:main Sep 20, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aimlops AI & MLOps awaiting CAB approval northstar Created by Project NorthStar
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants