Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Product Partnerships] Updated Amazon Sagemaker Entity #2002

Merged
merged 16 commits into from
Sep 11, 2023
Merged

[Product Partnerships] Updated Amazon Sagemaker Entity #2002

merged 16 commits into from
Sep 11, 2023

Conversation

SuruchiSaboo
Copy link
Contributor

[Product Partnerships] Updated Amazon Sagemaker Entity

Pre merge checklist

  • Did you check you NRQL syntax? - Does it work?
  • Did you include a Data source and Documentation reference?
  • Are all documentation links publicly accessible?
  • Did you check your descriptive content for voice and tone?
  • Did you check your descriptive content for spelling and grammar errors?
  • Did you review your content with a subject matter expert? (e.g. a Browser agent quickstart is reviewed with a member of the Browser Agent team)

Dashboards

  • Does the PR contain a screenshot for each of your dashboards?
  • Do your screenshots show data?
  • Has the sanitization script been run on each dashboard?

Alerts

  • Did you check that your alerts actually work?

@SuruchiSaboo SuruchiSaboo requested a review from seemantk as a code owner August 31, 2023 12:34
@github-actions
Copy link

Thank you for your contribution, our team will be reviewing this shortly, please be available for any follow up questions or code review feedback!

josephgregoryii
josephgregoryii previously approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@josephgregoryii josephgregoryii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! @seemantk for final approval

seemantk
seemantk previously approved these changes Sep 4, 2023
View reviewed changes
Copy link
Contributor

@seemantk seemantk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. getting freeze exception

@seemantk seemantk added aimlops AI & MLOps northstar Created by Project NorthStar labels Sep 7, 2023
d3caf
d3caf previously approved these changes Sep 7, 2023
View reviewed changes
pkosanam
pkosanam approved these changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@pkosanam pkosanam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdumpati mdumpati merged commit 48853dc into newrelic:main Sep 11, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkosanam pkosanam pkosanam approved these changes

@d3caf d3caf d3caf left review comments

@seemantk seemantk seemantk left review comments

@josephgregoryii josephgregoryii Awaiting requested review from josephgregoryii

Assignees
No one assigned
Labels
aimlops AI & MLOps northstar Created by Project NorthStar
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@SuruchiSaboo @seemantk @d3caf @josephgregoryii @pkosanam @mdumpati @aj-NR @rahul188