Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NR-154436-SonarQube improvement quickstart. #1999

Merged
merged 2 commits into from
Sep 11, 2023

Conversation

pkudikyala
Copy link
Contributor

Jira Ticket: https://issues.newrelic.com/browse/NR-154436
Description: This PR has the improvement quickstart integration named "SonarQube"
Dashboard: https://onenr.io/0ZQWYJVGeRW

Summary

A concise description of the changes being introduced. Please review the pre-merge checklist section to validate this pull request is ready for review and merge. If it is not ready, please mark the pull request as a draft.

The owners of this repo are not experts in the subject matter of the quickstarts. We review for the quickstart to be functional and for security risks. If you are seeking feedback on the content of the quickstart, please seek out a subject matter expert. If you are not an internal NR contributor, we can do our best to connect you with a content reviewer.

Pre merge checklist

  • Did you check you NRQL syntax? - Does it work?
  • Did you include a Data source and Documentation reference?
  • Are all documentation links publicly accessible?
  • Did you check your descriptive content for voice and tone?
  • Did you check your descriptive content for spelling and grammar errors?
  • Did you review your content with a subject matter expert? (e.g. a Browser agent quickstart is reviewed with a member of the Browser Agent team)

Dashboards

  • Does the PR contain a screenshot for each of your dashboards?
  • Do your screenshots show data?
  • Has the sanitization script been run on each dashboard?

Alerts

  • Did you check that your alerts actually work?

@pkudikyala pkudikyala requested a review from seemantk as a code owner August 30, 2023 09:12
@github-actions
Copy link

Thank you for your contribution, our team will be reviewing this shortly, please be available for any follow up questions or code review feedback!

@pkudikyala pkudikyala changed the title NR-154436-SonarQube improvement with JMX config. NR-154436-SonarQube improvement quickstart. Aug 30, 2023
@pkosanam pkosanam added the Tara Submitted by a team member from Tara team (Previously CXPUI team) in HYD label Sep 11, 2023
Copy link
Contributor

@pkosanam pkosanam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@seemantk seemantk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pkosanam pkosanam merged commit 978b27a into newrelic:main Sep 11, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improved-quickstart Tara Submitted by a team member from Tara team (Previously CXPUI team) in HYD
Projects
Development

Successfully merging this pull request may close these issues.

3 participants