Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defensively check GQL path parts in framework_graphql #829

Closed
wants to merge 2 commits into from
Closed

Defensively check GQL path parts in framework_graphql #829

wants to merge 2 commits into from

Conversation

jollysahil
Copy link

Overview

When constructing deepest path, removes None values from path parts and fields

Related Github Issue

#814

Testing

The agent includes a suite of tests which should be used to
verify your changes don't break existing functionality. These tests will run with
Github Actions when a pull request is made. More details on running the tests locally can be found
here,
For most contributions it is strongly recommended to add additional tests which
exercise your changes.

@jollysahil jollysahil requested a review from a team June 12, 2023 19:48
@CLAassistant
Copy link

CLAassistant commented Jun 12, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@hmstepanek hmstepanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing a fix for this! Could you also create a test that reproduces the error in #814?

@jollysahil
Copy link
Author

@hmstepanek thanks for your review, I have pushed up a query which I believe causes the error. I haven't been able to get the test to run locally - do you have any documentation on the steps needed to install dependencies/run tests?

@jollysahil
Copy link
Author

@hmstepanek just checking back on this?

@jollysahil
Copy link
Author

closing due to lack of follow up

@jollysahil jollysahil closed this Aug 2, 2023
@jollysahil jollysahil deleted the sj/fix-814 branch August 2, 2023 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants