Add adaptive sampling target config options & instances #1577

hmstepanek · 2025-11-12T00:54:53Z

Overview

Add adaptive sampling target config options & instances:

Add support for *.adaptive.sampling_target configuration settings.
Add support for multiple instances of adaptive sampler.

* fix(aiomysql): avoid wrapping pooled connections multiple times * Move and rewrite regression test * Tweak implementation of fix --------- Co-authored-by: Tim Pansino <[email protected]>

Bumps the github_actions group with 4 updates: [actions/upload-artifact](https://github.com/actions/upload-artifact), [actions/download-artifact](https://github.com/actions/download-artifact), [astral-sh/setup-uv](https://github.com/astral-sh/setup-uv) and [github/codeql-action](https://github.com/github/codeql-action). Updates `actions/upload-artifact` from 4.6.2 to 5.0.0 - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@ea165f8...330a01c) Updates `actions/download-artifact` from 5.0.0 to 6.0.0 - [Release notes](https://github.com/actions/download-artifact/releases) - [Commits](actions/download-artifact@634f93c...018cc2c) Updates `astral-sh/setup-uv` from 7.1.1 to 7.1.2 - [Release notes](https://github.com/astral-sh/setup-uv/releases) - [Commits](astral-sh/setup-uv@2ddd2b9...8585678) Updates `github/codeql-action` from 4.30.9 to 4.31.0 - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@16140ae...4e94bd1) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-version: 5.0.0 dependency-type: direct:production update-type: version-update:semver-major dependency-group: github_actions - dependency-name: actions/download-artifact dependency-version: 6.0.0 dependency-type: direct:production update-type: version-update:semver-major dependency-group: github_actions - dependency-name: astral-sh/setup-uv dependency-version: 7.1.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: github_actions - dependency-name: github/codeql-action dependency-version: 4.31.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: github_actions ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Timothy Pansino <[email protected]>

Bumps the github_actions group with 1 update: [github/codeql-action](https://github.com/github/codeql-action). Updates `github/codeql-action` from 4.31.0 to 4.31.2 - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@4e94bd1...0499de3) --- updated-dependencies: - dependency-name: github/codeql-action dependency-version: 4.31.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: github_actions ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Modify extractor logic. * Add support for Claude Sonnet 3+ and region aware models. * Update claude content extraction logic. * Add support for Claude Sonnet 3+ and region aware models. * Update claude content extraction logic. * Add testing for aiobotocore. * Restore newline. --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

…1568) This reverts commit b9d9d3b.

* Enable env vars for attribute filters * [MegaLinter] Apply linters fixes * Trigger tests * Change attribute filters to space delimited * Fix test assertion --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Tim Pansino <[email protected]>

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

github-actions · 2025-11-12T00:56:20Z

✅MegaLinter analysis: Success

Descriptor	Linter	Files	Fixed	Elapsed time
✅ ACTION	actionlint	7		0.99s
✅ MARKDOWN	markdownlint	7	0	1.41s
✅ PYTHON	ruff	950	0	1.06s
✅ PYTHON	ruff-format	950	0	0.38s
✅ YAML	prettier	15	0	1.49s
✅ YAML	v8r	15		5.34s
✅ YAML	yamllint	15		0.71s

See detailed reports in MegaLinter artifacts

codecov-commenter · 2025-11-12T01:00:28Z

Codecov Report

❌ Patch coverage is 82.29508% with 54 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.23%. Comparing base (f181585) to head (6945e5a).

Files with missing lines	Patch %	Lines
newrelic/config.py	45.20%	40 Missing ⚠️
newrelic/core/data_collector.py	42.85%	3 Missing and 1 partial ⚠️
newrelic/core/application.py	62.50%	1 Missing and 2 partials ⚠️
newrelic/core/config.py	93.87%	2 Missing and 1 partial ⚠️
newrelic/core/node_mixin.py	94.91%	1 Missing and 2 partials ⚠️
newrelic/api/transaction.py	98.36%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1577      +/-   ##
==========================================
- Coverage   81.83%   80.23%   -1.60%     
==========================================
  Files         207      208       +1     
  Lines       23970    24197     +227     
  Branches     3803     3831      +28     
==========================================
- Hits        19615    19414     -201     
- Misses       3087     3437     +350     
- Partials     1268     1346      +78

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

* Skip hypercorn tests for v0.18 * Remove tornadomaster for 3.14

Bumps the github_actions group with 5 updates in the / directory: | Package | From | To | | --- | --- | --- | | [actions/checkout](https://github.com/actions/checkout) | `5.0.0` | `5.0.1` | | [docker/metadata-action](https://github.com/docker/metadata-action) | `5.8.0` | `5.9.0` | | [docker/setup-qemu-action](https://github.com/docker/setup-qemu-action) | `3.6.0` | `3.7.0` | | [astral-sh/setup-uv](https://github.com/astral-sh/setup-uv) | `7.1.2` | `7.1.3` | | [github/codeql-action](https://github.com/github/codeql-action) | `4.31.2` | `4.31.3` | Updates `actions/checkout` from 5.0.0 to 5.0.1 - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@08c6903...93cb6ef) Updates `docker/metadata-action` from 5.8.0 to 5.9.0 - [Release notes](https://github.com/docker/metadata-action/releases) - [Commits](docker/metadata-action@c1e5197...318604b) Updates `docker/setup-qemu-action` from 3.6.0 to 3.7.0 - [Release notes](https://github.com/docker/setup-qemu-action/releases) - [Commits](docker/setup-qemu-action@2910929...c7c5346) Updates `astral-sh/setup-uv` from 7.1.2 to 7.1.3 - [Release notes](https://github.com/astral-sh/setup-uv/releases) - [Commits](astral-sh/setup-uv@8585678...5a7eac6) Updates `github/codeql-action` from 4.31.2 to 4.31.3 - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@0499de3...014f16e) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: 5.0.1 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: github_actions - dependency-name: docker/metadata-action dependency-version: 5.9.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: github_actions - dependency-name: docker/setup-qemu-action dependency-version: 3.7.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: github_actions - dependency-name: astral-sh/setup-uv dependency-version: 7.1.3 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: github_actions - dependency-name: github/codeql-action dependency-version: 4.31.3 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: github_actions ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

* Runner instrumentation in asyncio * Clean up asyncio instrumentation * Add asyncio tests for loop_factory * Modify uvicorn test for loop_factory * Fix linter errors * [MegaLinter] Apply linters fixes * Apply suggestions from code review --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Tim Pansino <[email protected]>

* Correct code for Sanic instrumentation * Correct handling of headers in ASGIWebTransaction * Correct handling of headers in ASGIBrowserMiddleware * Add regression test for ASGI headers issues --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

TimPansino and others added 14 commits October 23, 2025 22:14

Fix error when shutdown_agent called from harvest thread (#1552)

fcaeb10

fix(aiomysql): avoid wrapping pooled connections multiple times (#1553)

996ee66

* fix(aiomysql): avoid wrapping pooled connections multiple times * Move and rewrite regression test * Tweak implementation of fix --------- Co-authored-by: Tim Pansino <[email protected]>

Fix structlog tests (#1556)

6d7be8c

Add instrumentation for new kinesis method (#1557)

d1e7b60

Add free-threaded Python to CI (#1562)

953f379

Fix notice_error logic for non-iterable exceptions. (#1564)

b9d9d3b

Revert "Fix notice_error logic for non-iterable exceptions. (#1564)" (#…

4cb31b1

…1568) This reverts commit b9d9d3b.

Add additional trace points for AWS Kinesis (#1569)

8577eb7

Update version of cibuildwheel to latest (#1570)

68252f0

Force uv to use non-emulated Python on windows arm64 (#1567)

81d01e1

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

hmstepanek requested a review from a team as a code owner November 12, 2025 00:54

hmstepanek marked this pull request as draft November 12, 2025 00:54

mergify bot added the tests-failing Tests failing in CI. label Nov 12, 2025

hmstepanek force-pushed the add-adaptive-sampler-instances branch from 1c11ccf to c5c315b Compare November 12, 2025 21:44

Skip hypercorn tests for v0.18 (#1579)

8d18c0a

* Skip hypercorn tests for v0.18 * Remove tornadomaster for 3.14

hmstepanek force-pushed the add-adaptive-sampler-instances branch 2 times, most recently from 63a75e0 to b986654 Compare November 17, 2025 22:27

Add support for *.adaptive.sampling_target

1708a4d

hmstepanek force-pushed the add-adaptive-sampler-instances branch from b986654 to 03896b6 Compare November 17, 2025 22:31

Add adaptive sampler instances to SamplerProxy

090b4c4

hmstepanek force-pushed the add-adaptive-sampler-instances branch from 27dddd5 to 090b4c4 Compare November 17, 2025 22:38

hmstepanek marked this pull request as ready for review November 17, 2025 22:38

mergify bot and others added 2 commits November 17, 2025 22:39

Merge branch 'main' into add-adaptive-sampler-instances

540290d

Fix instability in CI caused by health check tests (#1584)

4193991

Merge branch 'main' into add-adaptive-sampler-instances

cb547e1

lrafeei self-assigned this Nov 17, 2025

dependabot bot and others added 6 commits November 17, 2025 16:20

Merge branch 'main' into add-adaptive-sampler-instances

40525c8

Merge branch 'main' into add-adaptive-sampler-instances

aa1ed3b

Merge branch 'main' into add-adaptive-sampler-instances

6945e5a

lrafeei approved these changes Nov 18, 2025

View reviewed changes

hmstepanek enabled auto-merge (squash) November 18, 2025 20:15

hmstepanek removed the tests-failing Tests failing in CI. label Nov 18, 2025

mergify bot added the tests-failing Tests failing in CI. label Nov 18, 2025

hmstepanek disabled auto-merge November 18, 2025 20:16

hmstepanek removed the tests-failing Tests failing in CI. label Nov 18, 2025

mergify bot added the tests-failing Tests failing in CI. label Nov 18, 2025

hmstepanek enabled auto-merge (squash) November 18, 2025 20:18

hmstepanek changed the base branch from main to develop-hybrid-core-tracing November 18, 2025 20:19

hmstepanek disabled auto-merge November 18, 2025 20:19

hmstepanek merged commit e87bd37 into develop-hybrid-core-tracing Nov 18, 2025
47 of 62 checks passed

hmstepanek deleted the add-adaptive-sampler-instances branch November 18, 2025 20:19

mergify bot removed the tests-failing Tests failing in CI. label Nov 18, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add adaptive sampling target config options & instances #1577

Add adaptive sampling target config options & instances #1577

Uh oh!

hmstepanek commented Nov 12, 2025

Uh oh!

github-actions bot commented Nov 12, 2025 •

edited

Loading

Uh oh!

codecov-commenter commented Nov 12, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Add adaptive sampling target config options & instances #1577

Add adaptive sampling target config options & instances #1577

Uh oh!

Conversation

hmstepanek commented Nov 12, 2025

Overview

Uh oh!

github-actions bot commented Nov 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅MegaLinter analysis: Success

Uh oh!

codecov-commenter commented Nov 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

github-actions bot commented Nov 12, 2025 •

edited

Loading

codecov-commenter commented Nov 12, 2025 •

edited

Loading