Add support for partial granularity type#1532
Merged
hmstepanek merged 24 commits intodevelop-hybrid-core-tracingfrom Nov 6, 2025
Merged
Add support for partial granularity type#1532hmstepanek merged 24 commits intodevelop-hybrid-core-tracingfrom
hmstepanek merged 24 commits intodevelop-hybrid-core-tracingfrom
Conversation
✅MegaLinter analysis: Success
See detailed reports in MegaLinter artifacts |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop-hybrid-core-tracing #1532 +/- ##
=============================================================
Coverage 81.76% 81.76%
=============================================================
Files 207 207
Lines 23943 24072 +129
Branches 3796 3819 +23
=============================================================
+ Hits 19576 19682 +106
- Misses 3101 3119 +18
- Partials 1266 1271 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
831fa32 to
ca79220
Compare
303468c to
27573b4
Compare
7282263 to
b59cc63
Compare
hmstepanek
commented
Oct 21, 2025
4c9dd32 to
b962aba
Compare
hmstepanek
commented
Oct 22, 2025
0262e1a to
81943d0
Compare
hmstepanek
commented
Oct 22, 2025
e3f2de1 to
01b71d0
Compare
ddd7851 to
d3152cb
Compare
d3152cb to
eaa838d
Compare
01b71d0 to
48c4420
Compare
lrafeei
requested changes
Oct 29, 2025
newrelic/core/config.py
Outdated
|
|
||
| application_settings.attribute_filter = AttributeFilter(flatten_settings(application_settings)) | ||
|
|
||
| simplify_distributed_tracing_sampler_granularity_settings(application_settings) |
Contributor
There was a problem hiding this comment.
I just realized that simplify_distributed_tracing_sampler_granularity_settings() should either
- be moved before the
attribute_filterapplication, but right afterapply_server_side_settings() - be removed all together and put the logic from that function in
apply_server_side_settings()(maybe after thecustom_insights_events.max_attribute_valueoverride?)
lrafeei
reviewed
Oct 30, 2025
newrelic/core/config.py
Outdated
|
|
||
| application_settings.attribute_filter = AttributeFilter(flatten_settings(application_settings)) | ||
|
|
||
| simplify_distributed_tracing_sampler_granularity_settings(application_settings) |
Contributor
There was a problem hiding this comment.
Since the logic for this has now moved to apply_server_side_settings(), the call to this function can be removed
80d39d5 to
9c14833
Compare
Bumps the github_actions group with 1 update: [github/codeql-action](https://github.com/github/codeql-action). Updates `github/codeql-action` from 4.31.0 to 4.31.2 - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@4e94bd1...0499de3) --- updated-dependencies: - dependency-name: github/codeql-action dependency-version: 4.31.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: github_actions ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Modify extractor logic. * Add support for Claude Sonnet 3+ and region aware models. * Update claude content extraction logic. * Add support for Claude Sonnet 3+ and region aware models. * Update claude content extraction logic. * Add testing for aiobotocore. * Restore newline. --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* Enable env vars for attribute filters * [MegaLinter] Apply linters fixes * Trigger tests * Change attribute filters to space delimited * Fix test assertion --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Tim Pansino <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
c08ab1a to
2040052
Compare
lrafeei
approved these changes
Nov 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Overview
This adds support for the concept of partial granularity distributed traces. There are 3 types:
Add support for the following new configuration options: