Add e2e tests for static targets #30
Conversation
gsanchezgavier
force-pushed
the
test-e2e
branch
2 times, most recently
from
7d7a16b to
79f55c2
Compare
gsanchezgavier
force-pushed
the
test-e2e
branch
from
79f55c2 to
1ea0103
Compare
gsanchezgavier
changed the title
| t.Setenv(configurator.LicenseKeyEnvKey, "") | ||
| t.Setenv(configurator.DataSourceNameEnvKey, "") |
There was a problem hiding this comment.
I was hitting an error since i configured the env vars to run the Tilt environment.
There was a problem hiding this comment.
not sure I am following, are they colliding?
There was a problem hiding this comment.
this test also covers the code where these env vars are expanded, if you have them in the session you are execute them , the test will fail (because of the expectations are checking other values for these).
I realize this "week" isolation because I exported this envars to run the e2e locally.
| scenarios: | ||
| - description: Scrape test environment metrics | ||
| before: | ||
| - cd ../../ && NR_PROM_LICENSE_KEY=${LICENSE_KEY} NR_PROM_CLUSTER=${SCENARIO_TAG} make tilt-ci |
There was a problem hiding this comment.
oh, this is not that nice, could it be a step of the pipeline? How nri-kubernetes works without this?
There was a problem hiding this comment.
I mean the cd ../../ &&
There was a problem hiding this comment.
also below tilt down is way more clear and simple
There was a problem hiding this comment.
agree is ugly, but is not complex i would say, is the simpler and clear solution i came up to actually re-use the make target and not duplicate bash scripts all over the repo.
There was a problem hiding this comment.
looks like there is another way but i found it more obscure WDYT
https://superuser.com/questions/370575/how-to-run-make-file-from-any-directory
paologallinaharbur
left a comment
paologallinaharbur
left a comment
There was a problem hiding this comment.
just some doubts regarding the parser_test
|
golangci-lint is failing because the just released 1.48 version deprecated the |
Executes the e2e test action using the Tilt environment and checks for expected metrics that are in the test environment.
Pending on future PRs