fix agent unit tests #994
Merged
fix agent unit tests #994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure including agent's source directory in the include search path. This used to be provided by 'broken' php build system which was fixed in PHP 8.4.
Closures are named differently on PHP 8.4.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feat/php-8.4/fix-api-number #994 +/- ##
==============================================================
Coverage ? 77.85%
==============================================================
Files ? 195
Lines ? 26363
Branches ? 0
==============================================================
Hits ? 20525
Misses ? 5838
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ZNeumann
approved these changes
Dec 11, 2024
lavarou
added a commit
that referenced
this pull request
Dec 16, 2024
PHP's build system received a fix for 'out of tree' builds. This broke build of agent's unit tests which require agent's source directory to be in the include search path. Working agent's unit tests showed that `test_function_debug_name` needed its expectations tweaked - closures are named differently on PHP 8.4.
zsistla
pushed a commit
that referenced
this pull request
Dec 20, 2024
PHP's build system received a fix for 'out of tree' builds. This broke build of agent's unit tests which require agent's source directory to be in the include search path. Working agent's unit tests showed that `test_function_debug_name` needed its expectations tweaked - closures are named differently on PHP 8.4.
lavarou
added a commit
that referenced
this pull request
Dec 20, 2024
PHP's build system received a fix for 'out of tree' builds. This broke build of agent's unit tests which require agent's source directory to be in the include search path. Working agent's unit tests showed that `test_function_debug_name` needed its expectations tweaked - closures are named differently on PHP 8.4.
ZNeumann
pushed a commit
that referenced
this pull request
Jan 7, 2025
PHP's build system received a fix for 'out of tree' builds. This broke build of agent's unit tests which require agent's source directory to be in the include search path. Working agent's unit tests showed that `test_function_debug_name` needed its expectations tweaked - closures are named differently on PHP 8.4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP's build system received a fix for 'out of tree' builds - see php/php-src#13516. This broke build of agent's unit tests which require agent's source directory to be in the include search path. Working agent's unit tests showed that
test_function_debug_nameneeded its expectations tweaked - closures are named differently on PHP 8.4.