Release 10.7 #628
Merged
Release 10.7 #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
version and codename update for next release.
1) Clarify wording in main `development.md` regarding integration test requirements. 2) Update `dev_environment.md` to reflect updates made in the dockerized dev environment.
Give the user an option to use `protobuf-c` from location alternative to `vendor` subdirectory via `PROTOBUF_C_PREFIX` environmental variable. `$PROTOBUF_C_PREFIX/bin` needs to have `protoc-c` binary, `$PROTOBUF_C_PREFIX/include` needs to have `protobuf-c/protobuf-c.h` header file and `$PROTOBUF_C_PREFIX/lib` needs to have `libprotobuf-c.a`. By default agent's build system will try to look for `protobuf-c` dependency in location returned by `pkg-config libprotobuf-c --variable=prefix`, a location where `protobuf-c` is installed in the system via package managers. If that location does not have `protobuf-c`, agent's build system will fallback to using `protobuf-c` from `vendor` directory. This enhancement speeds up agent build because neither `vendor/protobuf` nor `vendor/protobuf-c` need to be build if `protobuf-c` is installed in the system by the user. If user or system provided `protobuf-c` does not meet agent's build system requirements, the build will abort with an error message. Force the agent to use static version of pcre library. This avoids the issue with runtime dependency on libpcre shared object, that is hard to satisfy universally, because different Linux distributions use different name of the shared object: libpcre.so or libpcre3.so. Additionally the user has an option to point to pcre library installation via `PCRE_PREFIX` environmental variable. By default agent's build system will try to look for pcre dependency using `pkg-config`. If user or system provided `pcre` does not meet agent's build system requirements, the build will abort with an error message. To troubleshoot build issues caused by dependencies, agent will log which dependencies it is using.
By default let the agent link to whatever libpcre is available on the system (most likely a shared object). However for release builds the agent needs to link with a static version of libpcre to ensure it runs on all Linux distros. This is needed because different Linux distributions use different names for the shared object and its impossible to link to a shared object that works universally on all Linux distributions. If PCRE_STATIC is set to yes, agent's build system will enforce linking to static version of libpcre and if it is not available, the build will abort. Supplements #613
Address gcc12 compilation warnings: 1. Use `#pragma GCC diagnostic ignored "-Waddress"` to silence "the comparison will always evaluate as 'false' for the address of 'val' will never be NULL" warnings for struct members that are defined as `char val[1]` 2. Unroll `nrunlikely` macro to help compiler understand NULL check in `nr_realloc` 3. Address `stringop-overflow` in `nr_php_call`, `nr_php_call_callable` and `nr_php_call_fcall_info` macros. --------- Co-authored-by: Michal Nowacki <[email protected]>
Co-authored-by: ZNeumann <[email protected]> Co-authored-by: Michal Nowacki <[email protected]> Co-authored-by: Michael Fulbright <[email protected]> Co-authored-by: mfulb <[email protected]>
lavarou
approved these changes
Mar 3, 2023
zsistla
approved these changes
Mar 3, 2023
ZNeumann
approved these changes
Mar 3, 2023
|
ok jenkins |
1 similar comment
|
ok jenkins |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.