Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Drop Node.js 16 #317

Merged
merged 2 commits into from
Jul 31, 2024
Merged

chore: Drop Node.js 16 #317

merged 2 commits into from
Jul 31, 2024

Conversation

bizob2828
Copy link
Member

Description

Please provide a brief description of the changes introduced in this pull request.
What problem does it solve? What is the context of this change?

How to Test

Please describe how you have tested these changes. Have you run the code against an example application?
What steps did you take to ensure that the changes are working correctly?

Related Issues

Please include any related issues or pull requests in this section, using the format Closes #<issue number> or Fixes #<issue number> if applicable.

…rver-express` to 3.0.0. Removed testing against `apollo-server-fastify`, `apollo-server-hapi`, `apollo-server-koa`, `apollo-server-lambda` as we found the plugin instrumentation had no effect on the relevant, deprecated pacakges (#315)
Copy link

codecov bot commented Jul 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.98%. Comparing base (ba5056a) to head (03c37b6).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #317   +/-   ##
=======================================
  Coverage   98.98%   98.98%           
=======================================
  Files           7        7           
  Lines         891      891           
=======================================
  Hits          882      882           
  Misses          9        9           
Flag Coverage Δ
integration-tests-16.x ?
integration-tests-18.x 93.93% <ø> (ø)
integration-tests-20.x 93.93% <ø> (ø)
integration-tests-22.x 93.93% <ø> (ø)
unit-tests-16.x ?
unit-tests-18.x 59.70% <ø> (ø)
unit-tests-20.x 59.70% <ø> (ø)
unit-tests-22.x 59.70% <ø> (ø)
versioned-tests-16.x ?
versioned-tests-18.x 95.84% <ø> (ø)
versioned-tests-20.x 95.84% <ø> (ø)
versioned-tests-22.x 95.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrickard mrickard self-assigned this Jul 31, 2024
@bizob2828 bizob2828 merged commit 60c2805 into main Jul 31, 2024
34 checks passed
@github-actions github-actions bot mentioned this pull request Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants